Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python,rust!): Allow specifying Hive schema in read/scan_parquet #15434

Merged
merged 26 commits into from
Apr 2, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Apr 2, 2024

Ref #15441

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Apr 2, 2024
@stinodego stinodego changed the title feat: Allow specifying Hive schema in read/scan_parquet feat(python,rust!): Allow specifying Hive schema in read/scan_parquet Apr 2, 2024
@github-actions github-actions bot added the breaking rust Change that breaks backwards compatibility for the Rust crate label Apr 2, 2024
@stinodego stinodego marked this pull request as ready for review April 2, 2024 13:43
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 85.64593% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 81.13%. Comparing base (e3c2b0d) to head (5a42bea).
Report is 2 commits behind head on main.

❗ Current head 5a42bea differs from pull request most recent head 6c97719. Consider uploading reports for the commit 6c97719 to get more accurate results

Files Patch % Lines
crates/polars-plan/src/logical_plan/hive.rs 88.76% 10 Missing ⚠️
crates/polars-io/src/predicates.rs 80.48% 8 Missing ⚠️
...c/logical_plan/optimizer/predicate_pushdown/mod.rs 0.00% 6 Missing ⚠️
crates/polars-plan/src/logical_plan/schema.rs 84.37% 5 Missing ⚠️
crates/polars-io/src/options.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15434   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files        1362     1362           
  Lines      174820   174916   +96     
  Branches     2531     2532    +1     
=======================================
+ Hits       141836   141918   +82     
- Misses      32500    32514   +14     
  Partials      484      484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment about Arc::unwrap... after that it can be merged. 👍

crates/polars-plan/src/logical_plan/schema.rs Outdated Show resolved Hide resolved
@stinodego stinodego merged commit cdbfdc1 into main Apr 2, 2024
24 checks passed
@stinodego stinodego deleted the hive-schema-param branch April 2, 2024 21:17
@c-peters c-peters added the accepted Ready for implementation label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation breaking rust Change that breaks backwards compatibility for the Rust crate enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants