Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust, python): Add null_on_oob parameter to expr.array.get #15426

Merged
merged 4 commits into from
Apr 10, 2024
Merged

feat(rust, python): Add null_on_oob parameter to expr.array.get #15426

merged 4 commits into from
Apr 10, 2024

Conversation

JamesCE2001
Copy link
Contributor

Another part of #15240

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Apr 1, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.57143% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.12%. Comparing base (b0ece1e) to head (32d5cb5).
Report is 57 commits behind head on main.

❗ Current head 32d5cb5 differs from pull request most recent head 17ad0c8. Consider uploading reports for the commit 17ad0c8 to get more accurate results

Files Patch % Lines
crates/polars-plan/src/dsl/function_expr/array.rs 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15426      +/-   ##
==========================================
- Coverage   81.13%   81.12%   -0.01%     
==========================================
  Files        1362     1362              
  Lines      174812   174866      +54     
  Branches     2531     2531              
==========================================
+ Hits       141829   141867      +38     
- Misses      32498    32514      +16     
  Partials      485      485

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ritchie46
ritchie46 reviewed Apr 10, 2024
View reviewed changes
crates/polars-ops/src/chunked_array/array/get.rs Outdated
@@ -40,3 +47,24 @@ pub fn array_get(ca: &ArrayChunked, index: &Int64Chunked) -> PolarsResult<Series
),
}
}

#[inline]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be inlined.

crates/polars-ops/src/chunked_array/array/get.rs Outdated Show resolved Hide resolved
@ritchie46
Copy link
Member

Thank you @JamesCE2001

@ritchie46 ritchie46 merged commit 8440457 into pola-rs:main Apr 10, 2024
24 checks passed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 10, 2024

CodSpeed Performance Report

Merging #15426 will not alter performance

Comparing JamesCE2001:array-get-null-oob (17ad0c8) with main (97c61fe)

Summary

✅ 22 untouched benchmarks

mbuhidar pushed a commit to mbuhidar/polars that referenced this pull request Apr 11, 2024
@JamesCE2001 @edwjames
@ritchie46 @mbuhidar
feat(rust, python): Add null_on_oob parameter to expr.array.get (p…
1b23059 
…ola-rs#15426)

Co-authored-by: James Edwards <[email protected]>
Co-authored-by: Ritchie Vink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 left review comments

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesCE2001 @ritchie46 @edwjames