Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Add non-order preserving variable row-encoding #15414

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

ritchie46
Copy link
Member

Optimize row-encoding for non-order preserving operations like group-by, join. By dropping that requirement we can simply memcopy the bytes and don't have to add padding bytes/blocks.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.14%. Comparing base (2b28777) to head (dd2a08f).

Files Patch % Lines
crates/polars-row/src/encode.rs 91.66% 4 Missing ⚠️
crates/polars-row/src/variable.rs 96.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15414   +/-   ##
=======================================
  Coverage   81.13%   81.14%           
=======================================
  Files        1361     1361           
  Lines      174667   174746   +79     
  Branches     2531     2531           
=======================================
+ Hits       141713   141789   +76     
- Misses      32471    32473    +2     
- Partials      483      484    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 5cdeea2 into main Apr 1, 2024
18 checks passed
@ritchie46 ritchie46 deleted the row_encode branch April 1, 2024 11:17
@c-peters c-peters added the accepted Ready for implementation label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants