Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): fix panic when doing a scan_parquet with hive partioning #15381

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

kszlim
Copy link
Contributor

@kszlim kszlim commented Mar 29, 2024

Seems to fix (the first bug reported in) #15375 for me, not sure if this is valid though? @ritchie46

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (a871359) to head (559258e).
Report is 3 commits behind head on main.

❗ Current head 559258e differs from pull request most recent head fd7558f. Consider uploading reports for the commit fd7558f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15381   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files        1361     1361           
  Lines      176489   176497    +8     
  Branches     2531     2531           
=======================================
+ Hits       143637   143644    +7     
- Misses      32366    32369    +3     
+ Partials      486      484    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

I got a repro, will add a test.

@ritchie46
Copy link
Member

Thank you @kszlim. To go forward we sometimes take small steps backward. :')

@ritchie46 ritchie46 merged commit 31bb26f into pola-rs:main Mar 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants