build(rust): Update Rust toolchain #15353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
changed the title
github-actions
bot
added
internal
stinodego
commented
Mar 28, 2024
| @@ -105,6 +105,7 @@ where | |||
| { | |||
| let mut mut_bitmap = MutableBitmap::with_capacity(array.len()); | |||
|
|
|||
| #[allow(clippy::manual_unwrap_or_default)] | |||
There was a problem hiding this comment.
This lint is currently broken:
rust-lang/rust-clippy#12580
stinodego
commented
Mar 28, 2024
Comment on lines
-269
to
-277
| /// Utility to write to `&mut Vec<u8>` buffer. | ||
| struct StringWrap<'a>(pub &'a mut Vec<u8>); | ||
|
|
||
| impl<'a> std::fmt::Write for StringWrap<'a> { | ||
| fn write_str(&mut self, s: &str) -> std::fmt::Result { | ||
| self.0.extend_from_slice(s.as_bytes()); | ||
| Ok(()) | ||
| } | ||
| } |
stinodego
commented
Mar 28, 2024
Comment on lines
-53
to
-75
| struct Iter<T, I: Iterator<Item = Option<T>>> { | ||
| current: i32, | ||
| offsets: std::vec::IntoIter<i32>, | ||
| values: I, | ||
| } | ||
|
|
||
| impl<T, I: Iterator<Item = Option<T>> + Clone> Iterator for Iter<T, I> { | ||
| type Item = Option<std::iter::Take<std::iter::Skip<I>>>; | ||
|
|
||
| fn next(&mut self) -> Option<Self::Item> { | ||
| let next = self.offsets.next(); | ||
| next.map(|next| { | ||
| let length = next - self.current; | ||
| let iter = self | ||
| .values | ||
| .clone() | ||
| .skip(self.current as usize) | ||
| .take(length as usize); | ||
| self.current = next; | ||
| Some(iter) | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
This struct was unused.
stinodego
commented
Mar 28, 2024
Comment on lines
+43
to
44
| #[allow(dead_code)] | ||
| pub num_values: usize, |
There was a problem hiding this comment.
This field is never used - do we need to keep it or can it be removed entirely?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15353 +/- ##
==========================================
- Coverage 81.41% 81.40% -0.02%
==========================================
Files 1362 1362
Lines 176734 176726 -8
Branches 2531 2531
==========================================
- Hits 143896 143867 -29
- Misses 32354 32375 +21
Partials 484 484 ☔ View full report in Codecov by Sentry. |
stinodego
force-pushed
the
bump-toolchain
branch
from
312ceba
to
bea305f
Compare
stinodego
requested review from
ritchie46,
orlp,
c-peters and
MarcoGorelli
as code owners
stinodego
force-pushed
the
bump-toolchain
branch
from
bea305f
to
933aa80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.