Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depr(python, rust!): Rename write_csv parameter quote to quote_char #11583

Merged
merged 11 commits into from
Oct 9, 2023
Merged

depr(python, rust!): Rename write_csv parameter quote to quote_char #11583

merged 11 commits into from
Oct 9, 2023

Commits on Oct 7, 2023

  1. Align parameters in scan_csv/read_csv/sink_csv/write_csv.

    @svaningelgem
    svaningelgem committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    99f9ef2 View commit details
    Browse the repository at this point in the history

  2. Align types across all csv methods

    @svaningelgem
    svaningelgem committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    b5404d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Merge remote-tracking branch 'origin/main' into fix_read_scan_write_c… 

    …sv_arguments

# Conflicts:
#	py-polars/tests/unit/namespaces/test_meta.py
    @svaningelgem
    svaningelgem committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    b1d9a74 View commit details
    Browse the repository at this point in the history

  2. Added @deprecate_renamed_parameter where necessary.

    @svaningelgem
    svaningelgem committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    516799f View commit details
    Browse the repository at this point in the history

  3. Renamed: delimiter_char --> separator

    @svaningelgem
    svaningelgem committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    8a68de2 View commit details
    Browse the repository at this point in the history

  4. removed the deprecations on separator.

    @svaningelgem
    svaningelgem committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    e4353d7 View commit details
    Browse the repository at this point in the history

  5. precommit ran

    @svaningelgem
    svaningelgem committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    eb9d212 View commit details
    Browse the repository at this point in the history

  6. processed PR comments

    @svaningelgem
    svaningelgem committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    7a0ca16 View commit details
    Browse the repository at this point in the history

  7. Loads of csv delimiter > separator.

    @svaningelgem
    svaningelgem committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    03b7e65 View commit details
    Browse the repository at this point in the history

  8. clippy linter error

    @svaningelgem
    svaningelgem committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    203bcdf View commit details
    Browse the repository at this point in the history

  9. Revert changes to type changes.

    @svaningelgem
    svaningelgem committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    c630dff View commit details
    Browse the repository at this point in the history