This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Fixes for examples in the User Guide #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aglebov
changed the title
c-peters
reviewed
Jul 5, 2023
|
The rest are great additions to the book, @aglebov once the query_plan section is fixed we can merge this in |
aglebov
force-pushed
the
fix-expressions-window
branch
from
5110859
to
80c0b1b
Compare
|
LGTM, thanks! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last example in Expressions / Window functions purports to select the fastest three and the strongest three pokemon for each type, so should perhaps be sorting rows in each group in descending order before picking the first 3.
The last example in Transformations / Joins is meant to demonstrate the effect of
tolerance = "1m", but does not actually use this argument.