Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show errors as snackbars #42

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Show errors as snackbars #42

wants to merge 3 commits into from

Conversation

Kwasow
Copy link
Member

@Kwasow Kwasow commented Jun 7, 2023

TODO: Snackbars show at top of the screen - should be at the bottom

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 25.92% and project coverage change: +0.88 🎉

Comparison is base (c07a808) 78.46% compared to head (016f7c0) 79.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   78.46%   79.35%   +0.88%     
==========================================
  Files          19       19              
  Lines        1607     1608       +1     
  Branches      167      179      +12     
==========================================
+ Hits         1261     1276      +15     
+ Misses        214      195      -19     
- Partials      132      137       +5     
Impacted Files Coverage Δ
...a/com/pokerio/app/components/PlayerListItemView.kt 66.07% <0.00%> (+2.27%) ⬆️
...rc/main/java/com/pokerio/app/screens/HomeScreen.kt 60.39% <0.00%> (+3.91%) ⬆️
...c/main/java/com/pokerio/app/screens/LobbyScreen.kt 72.18% <0.00%> (+2.10%) ⬆️
...ain/java/com/pokerio/app/screens/SettingsScreen.kt 81.70% <0.00%> (+2.03%) ⬆️
...rc/main/java/com/pokerio/app/screens/GameScreen.kt 76.12% <20.00%> (+2.39%) ⬆️
app/src/main/java/com/pokerio/app/MainActivity.kt 48.10% <25.00%> (-2.61%) ⬇️
...c/main/java/com/pokerio/app/utils/PokerioLogger.kt 72.72% <57.14%> (-27.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant