refactor: Use a slice of pointers for exports to allow swapping backe…

…nds at later points
pojntfx · Aug 8, 2023 · 9a16d1a · 9a16d1a
1 parent 72b3d30
commit 9a16d1a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/cmd/go-nbd-example-server-file/main.go b/cmd/go-nbd-example-server-file/main.go
@@ -75,7 +75,7 @@ func main() {
 
 			if err := server.Handle(
 				conn,
-				[]server.Export{
+				[]*server.Export{
 					{
 						Name:        *name,
 						Description: *description,

diff --git a/cmd/go-nbd-example-server-memory/main.go b/cmd/go-nbd-example-server-memory/main.go
@@ -60,7 +60,7 @@ func main() {
 
 			if err := server.Handle(
 				conn,
-				[]server.Export{
+				[]*server.Export{
 					{
 						Name:        *name,
 						Description: *description,

diff --git a/pkg/server/nbd.go b/pkg/server/nbd.go
@@ -34,7 +34,7 @@ type Options struct {
 	MaximumBlockSize   uint32
 }
 
-func Handle(conn net.Conn, exports []Export, options *Options) error {
+func Handle(conn net.Conn, exports []*Export, options *Options) error {
 	if options == nil {
 		options = &Options{
 			ReadOnly: false,
@@ -93,7 +93,7 @@ n:
 
 			for _, candidate := range exports {
 				if candidate.Name == string(exportName) {
-					export = &candidate
+					export = candidate
 
 					break
 				}