Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pods 3.2.7.1 #7365

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Pods 3.2.7.1 #7365

merged 2 commits into from
Oct 9, 2024

Conversation

PodsBot
Copy link
Collaborator

@PodsBot PodsBot commented Oct 9, 2024

Automated changes by create-pull-request GitHub action

@PodsBot PodsBot added this to the Pods 3.2.7.1 milestone Oct 9, 2024
@what-the-diff What The Diff
Copy link

what-the-diff bot commented Oct 9, 2024 •
edited
Loading

PR Summary

  • Enhanced Security Update: A new software version (3.2.7.1) was released on October 9th, 2024. This version marked notable improvements to security, particularly pertaining to the use of text headers and the types of code (HTML tags) that can be employed.
  • Version Number Refresh: This update affected various files within the system, namely init.php, package.json, and readme.txt. They have been updated to reflect the new version number, shifting from 3.2.7 to 3.2.7.1.
  • Heading Field Security Improvement: Security enhancements have been implemented into the heading.php file, reducing the range of acceptable HTML tags that can be used in heading fields. This measure protects against potential harmful scripts.
  • Documentation Updates: References have been updated throughout the software, specifically within PodsAdmin.php. Documentation referred to the year 2023 has been updated to reflect the current year, 2024.
  • User Interface Modification: To improve visibility and consistency, the default tags regarding headings displayed in various user interface components and JavaScript files have changed from 'h3' to 'h2'.
  • New Functionality Added to Heading Class: A new function, get_heading_tag, has been incorporated within the heading class. This additional feature will help enforce the use of approved HTML tags for headings and provide a default in case none is specified.

@sc0ttkclark sc0ttkclark marked this pull request as ready for review October 9, 2024 18:44
@sc0ttkclark sc0ttkclark merged commit 26fc546 into main Oct 9, 2024
8 of 17 checks passed
@sc0ttkclark sc0ttkclark deleted the release/3.2.7.1 branch October 9, 2024 18:44
PodsBot
PodsBot commented Oct 9, 2024
View reviewed changes
classes/PodsAdmin.php
@@ -2038,7 +2038,7 @@ public function get_callouts() {

// Handle callouts logic.
$callouts['access_rights'] = ! isset( $callouts['access_rights'] ) || $callouts['access_rights'] ? 1 : 0;
$callouts['friends_2023_docs'] = ! isset( $callouts['friends_2023_docs'] ) || $callouts['friends_2023_docs'] || $force_callouts ? 1 : 0;
$callouts['friends_2024_docs'] = ! isset( $callouts['friends_2024_docs'] ) || $callouts['friends_2024_docs'] || $force_callouts ? 1 : 0;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

ui/forms/div-row.php
@@ -17,7 +17,7 @@
<div class="pods-field__container pods-field-option <?php echo esc_attr( $row_classes ); ?>"
style="<?php echo esc_attr( 'hidden' == $field['type'] ? 'display:none;' : '' ); ?>">
<?php if ( 'heading' === $field['type'] ) : ?>
<?php $heading_tag = pods_v( $field['type'] . '_tag', $field, isset( $heading_tag ) ? $heading_tag : 'h2', true ); ?>
<?php $heading_tag = PodsField_Heading::get_heading_tag( $field, 'h2' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$heading_tag".

ui/forms/list-row.php
@@ -17,7 +17,7 @@
<li class="pods-field__container pods-field-option <?php echo esc_attr( $row_classes ); ?>"
style="<?php echo esc_attr( 'hidden' == $field['type'] ? 'display:none;' : '' ); ?>">
<?php if ( 'heading' === $field['type'] ) : ?>
<?php $heading_tag = pods_v( $field['type'] . '_tag', $field, isset( $heading_tag ) ? $heading_tag : 'h2', true ); ?>
<?php $heading_tag = PodsField_Heading::get_heading_tag( $field, 'h2' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$heading_tag".

ui/forms/p-row.php
@@ -16,7 +16,7 @@
?>
<div class="pods-field__container pods-field-option" style="<?php echo esc_attr( 'hidden' == $field['type'] ? 'display:none;' : '' ); ?>">
<?php if ( 'heading' === $field['type'] ) : ?>
<?php $heading_tag = pods_v( $field['type'] . '_tag', $field, isset( $heading_tag ) ? $heading_tag : 'h2', true ); ?>
<?php $heading_tag = PodsField_Heading::get_heading_tag( $field, 'h2' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$heading_tag".

ui/forms/table-row.php
@@ -18,7 +18,7 @@
<tr valign="top" class="pods-field__container pods-field-option <?php echo esc_attr( $row_classes ); ?>"
style="<?php echo esc_attr( 'hidden' == $field['type'] ? 'display:none;' : '' ); ?>">
<?php if ( 'heading' === $field['type'] ) : ?>
<?php $heading_tag = pods_v( $field['type'] . '_tag', $field, isset( $heading_tag ) ? $heading_tag : 'h2', true ); ?>
<?php $heading_tag = PodsField_Heading::get_heading_tag( $field, 'h2' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$heading_tag".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc0ttkclark sc0ttkclark Awaiting requested review from sc0ttkclark sc0ttkclark is a code owner

@JoryHogeveen JoryHogeveen Awaiting requested review from JoryHogeveen JoryHogeveen is a code owner

Assignees

@sc0ttkclark sc0ttkclark

Labels
Type: Release
Projects
None yet
Milestone
Pods 3.2.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@PodsBot @sc0ttkclark