Pods 3.0.6 #7193
Pods 3.0.6 #7193
Conversation
There was a problem hiding this comment.
Code analysis identified issues
action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 2 errors
Powered by rtCamp's GitHub Actions Library
| @@ -67,6 +67,7 @@ public function __toString() { | |||
| * | |||
| * @return bool Whether the offset exists. | |||
| */ | |||
| #[\ReturnTypeWillChange] | |||
There was a problem hiding this comment.
🚫 Error: Attributes are not supported in PHP 7.4 or earlier. Found: #[\ReturnTypeWillChange] (PHPCompatibility.Attributes.NewAttributes.Found).
| @@ -372,6 +372,7 @@ public function __toString() { | |||
| * | |||
| * @return bool Whether the offset exists. | |||
| */ | |||
| #[\ReturnTypeWillChange] | |||
There was a problem hiding this comment.
🚫 Error: Attributes are not supported in PHP 7.4 or earlier. Found: #[\ReturnTypeWillChange] (PHPCompatibility.Attributes.NewAttributes.Found).
…ed and add additional checks to prevent loading during plugin activation
There was a problem hiding this comment.
Code analysis identified issues
action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 8 errors
Powered by rtCamp's GitHub Actions Library
| @@ -56,6 +56,7 @@ public static function init( Whatsit $field ) { | |||
| * | |||
| * @uses Whatsit::__toString() | |||
| */ | |||
| #[\ReturnTypeWillChange] | |||
There was a problem hiding this comment.
🚫 Error: Attributes are not supported in PHP 7.4 or earlier. Found: #[\ReturnTypeWillChange] (PHPCompatibility.Attributes.NewAttributes.Found).
| @@ -78,6 +80,7 @@ public function offsetExists( $offset ) { | |||
| * | |||
| * @return mixed|null Offset value, or null if not set. | |||
| */ | |||
| #[\ReturnTypeWillChange] | |||
There was a problem hiding this comment.
🚫 Error: Attributes are not supported in PHP 7.4 or earlier. Found: #[\ReturnTypeWillChange] (PHPCompatibility.Attributes.NewAttributes.Found).
| @@ -118,6 +121,7 @@ public function offsetUnset( $offset ) { | |||
| * | |||
| * @uses Whatsit::__isset() | |||
| */ | |||
| #[\ReturnTypeWillChange] | |||
There was a problem hiding this comment.
🚫 Error: Attributes are not supported in PHP 7.4 or earlier. Found: #[\ReturnTypeWillChange] (PHPCompatibility.Attributes.NewAttributes.Found).
| @@ -135,6 +139,7 @@ public function __isset( $offset ) { | |||
| * | |||
| * @uses Whatsit::__get() | |||
| */ | |||
| #[\ReturnTypeWillChange] | |||
There was a problem hiding this comment.
🚫 Error: Attributes are not supported in PHP 7.4 or earlier. Found: #[\ReturnTypeWillChange] (PHPCompatibility.Attributes.NewAttributes.Found).
| @@ -186,6 +191,7 @@ public function __unset( $offset ) { | |||
| * | |||
| * @return mixed The method response. | |||
| */ | |||
| #[\ReturnTypeWillChange] | |||
There was a problem hiding this comment.
🚫 Error: Attributes are not supported in PHP 7.4 or earlier. Found: #[\ReturnTypeWillChange] (PHPCompatibility.Attributes.NewAttributes.Found).
| @@ -361,6 +361,7 @@ public function valid(): bool { | |||
| * | |||
| * @return string Object identifier. | |||
| */ | |||
| #[\ReturnTypeWillChange] | |||
There was a problem hiding this comment.
🚫 Error: Attributes are not supported in PHP 7.4 or earlier. Found: #[\ReturnTypeWillChange] (PHPCompatibility.Attributes.NewAttributes.Found).
| @@ -422,6 +424,7 @@ public function offsetUnset( $offset ): void { | |||
| * | |||
| * @return bool Whether the offset exists. | |||
| */ | |||
| #[\ReturnTypeWillChange] | |||
There was a problem hiding this comment.
🚫 Error: Attributes are not supported in PHP 7.4 or earlier. Found: #[\ReturnTypeWillChange] (PHPCompatibility.Attributes.NewAttributes.Found).
| @@ -453,6 +456,7 @@ public function __isset( $offset ) { | |||
| * | |||
| * @return mixed|null Offset value, or null if not set. | |||
| */ | |||
| #[\ReturnTypeWillChange] | |||
There was a problem hiding this comment.
🚫 Error: Attributes are not supported in PHP 7.4 or earlier. Found: #[\ReturnTypeWillChange] (PHPCompatibility.Attributes.NewAttributes.Found).
No description provided.