Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pods delete redirect fix (admin url) #7162

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Pods delete redirect fix (admin url) #7162

merged 3 commits into from
Sep 12, 2023

Conversation

JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Sep 11, 2023 •
edited
Loading

Description

Creates a config param for the admin URL and uses it for redirection after Pods deletion.

Related GitHub issue(s)

Fixes #7137

Testing instructions

Requires a WP network installation with subfolders.

  1. Create Pod
  2. Click delete > previously redirects to main site in a network
  3. Apply patch
  4. Click delete > will not stay in the current site in the network

Changelog text for these changes

PR checklist

@JoryHogeveen JoryHogeveen added Type: Bug Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pass QA passed Component: React Issues related to React JS labels Sep 11, 2023
@JoryHogeveen JoryHogeveen added this to the Pods 3.0 milestone Sep 11, 2023
@JoryHogeveen JoryHogeveen self-assigned this Sep 11, 2023
@JoryHogeveen JoryHogeveen changed the title Feature/7137 delete redirect Pods delete redirect fix (admin url) Sep 11, 2023
@JoryHogeveen JoryHogeveen changed the base branch from main to release/3.0 September 11, 2023 09:15
@what-the-diff
Copy link

what-the-diff bot commented Sep 11, 2023 •
edited
Loading

PR Summary

  • Configuration Modification in PodsInit.php
    The previously static configuration now has an additional setting, extending overall flexibility.

  • Version Update in pods-dfv.min.asset.json
    This reflects an upgrade in the version, indicating improvements and potentially new features.

  • Dynamic Redirect URL Change in postbox.js
    The redirection process has been enhanced by utilizing a dynamic source for the URL. This allows for more efficient and versatile page navigations.

@sc0ttkclark
Merge branch 'release/3.0' into feature/7137-delete-redirect
4974ac4 
# Conflicts:
#	ui/js/dfv/pods-dfv.min.asset.json
#	ui/js/dfv/pods-dfv.min.js
@sc0ttkclark sc0ttkclark merged commit 4974ac4 into release/3.0 Sep 12, 2023
6 of 9 checks passed
@sc0ttkclark sc0ttkclark deleted the feature/7137-delete-redirect branch September 12, 2023 14:48
@sc0ttkclark sc0ttkclark mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc0ttkclark sc0ttkclark sc0ttkclark approved these changes

Assignees

@JoryHogeveen JoryHogeveen

Labels
Component: React Issues related to React JS Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pass QA passed Type: Bug
Projects
React Work
Status: ✅ Done
Milestone
Pods 3.0
Development

Successfully merging this pull request may close these issues.

Error in redirecting after pods deletion
2 participants
@JoryHogeveen @sc0ttkclark