Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP version to 8.1 and see how Slic runs #7042

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update PHP version to 8.1 and see how Slic runs #7042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd4c5be
Update PHP version to 8.1 and see how Slic runs
sc0ttkclark Mar 28, 2023
b8130c4
Update Slic env file to use 8.1
sc0ttkclark Mar 28, 2023
2ea4d83
Move slic env setting
sc0ttkclark Mar 28, 2023
ceba567
Update PHP version in Slic env files too
sc0ttkclark Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,6 @@ CHROMEDRIVER_PORT=4444
# URL whatever URL we reach it with.
# See the `dev/docker/wp-config.php` template for more information.
WP_CHROMEDRIVER_URL="wp.test"

# Specify the PHP version to test on.
SLIC_PHP_VERSION="8.1"
3 changes: 3 additions & 0 deletions .env.testing.slic
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,6 @@ WP_CHROMEDRIVER_URL=http://wordpress.test

# We're using Docker to run the tests.
USING_CONTAINERS=1

# Specify the PHP version to test on.
SLIC_PHP_VERSION="8.1"
10 changes: 2 additions & 8 deletions .github/workflows/tests-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,6 @@ jobs:
fetch-depth: 1000
submodules: recursive
# ------------------------------------------------------------------------------
# Set up PHP to run slic
# ------------------------------------------------------------------------------
- name: Configure PHP environment
uses: shivammathur/setup-php@v2
with:
php-version: 7.4
# ------------------------------------------------------------------------------
# Checkout slic
# ------------------------------------------------------------------------------
- name: Checkout slic
Expand Down Expand Up @@ -72,6 +65,7 @@ jobs:
echo "SLIC_BIN=${GITHUB_WORKSPACE}/slic/slic" >> $GITHUB_ENV
echo "SLIC_WP_DIR=${GITHUB_WORKSPACE}/slic/_wordpress" >> $GITHUB_ENV
echo "SLIC_WORDPRESS_DOCKERFILE=Dockerfile.base" >> $GITHUB_ENV
echo "SLIC_PHP_VERSION=8.1" >> $GITHUB_ENV
- name: Set run context for slic
run: echo "SLIC=1" >> $GITHUB_ENV && echo "CI=1" >> $GITHUB_ENV
- name: Start ssh-agent
Expand Down Expand Up @@ -100,7 +94,7 @@ jobs:
docker network prune -f
${SLIC_BIN} use pods
${SLIC_BIN} composer set-version 2
${SLIC_BIN} composer install
${SLIC_BIN} composer install --no-dev
# ------------------------------------------------------------------------------
# Init WordPress container
# ------------------------------------------------------------------------------
Expand Down