Use static cache so the REST user authenticated can be test-friendly

pods-framework · Aug 28, 2024 · 5d26a32 · 5d26a32
1 parent c7d542d
commit 5d26a32
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/classes/PodsRESTFields.php b/classes/PodsRESTFields.php
@@ -25,13 +25,6 @@ class PodsRESTFields {
 	 */
 	protected $pod = null;
 
-	/**
-	 * The user ID for the authenticated user.
-	 *
-	 * @var int
-	 */
-	private static $rest_user_id;
-
 	/**
 	 * Constructor for class
 	 *
@@ -115,13 +108,20 @@ public function set_pod( $pod ) {
 	 * @return bool
 	 */
 	public static function is_rest_authenticated(): bool {
-		if ( isset( self::$rest_user_id ) ) {
-			return ! empty( self::$rest_user_id );
+		$is_rest_authenticated = (bool) pods_static_cache_get( __FUNCTION__, __CLASS__ );
+
+		if ( $is_rest_authenticated ) {
+			return true;
 		}
 
-		self::$rest_user_id = wp_validate_application_password( get_current_user_id() );
+		$is_rest_authenticated = (
+			is_user_logged_in()
+			|| wp_validate_application_password( get_current_user_id() )
+		);
+
+		pods_static_cache_set( __FUNCTION__, (int) $is_rest_authenticated, __CLASS__ );
 
-		return ! empty( self::$rest_user_id );
+		return $is_rest_authenticated;
 	}
 
 	/**

diff --git a/tests/codeception/wpunit/Pods/PodsRESTFieldsTest.php b/tests/codeception/wpunit/Pods/PodsRESTFieldsTest.php