CI: run rspec in GitHub Actions #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YusukeHosonuma
force-pushed
the
ci/run-rspec
branch
from
65b2766
to
9b3b0d1
Compare
YusukeHosonuma
force-pushed
the
ci/run-rspec
branch
from
9b3b0d1
to
6eb2e3d
Compare
YusukeHosonuma
commented
Feb 16, 2020
Comment on lines
+27
to
+29
| - name: Run test | ||
| run: | | ||
| rake test |
There was a problem hiding this comment.
ここ以外はmain.ymlからコピーしてきているので変更はありません。
YusukeHosonuma
commented
Feb 16, 2020
| @@ -1,5 +1,9 @@ | |||
| # AutoReserve | |||
|
|
|||
| [](https://github.com/po-miyasaka/AutoReserve/actions?query=workflow%3ATest) | |||
There was a problem hiding this comment.
Actions タブ > Create status badge から作成しています。
YusukeHosonuma
commented
Feb 16, 2020
Comment on lines
+4
to
+5
| [](https://github.com/po-miyasaka/AutoReserve/blob/master/LICENSE) | ||
| [](https://twitter.com/po_miyasaka) |
There was a problem hiding this comment.
YusukeHosonuma
commented
Feb 16, 2020
| @@ -1,4 +1,4 @@ | |||
| name: Run danger | |||
| name: Rubocop | |||
There was a problem hiding this comment.
どういう命名にするかは少し迷ったのですが、ワークフローの一覧に表示されて直感的と思える名称にしました（ファイル名もそれに合わせています）。
|
あざます！！！！めちゃくちゃありがたやなプルリク😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions で Rspec も実行するようにしました。
masterブランチにマージされた時でも実行されるように、pushトリガーで RSpec を実行するワークフローrspec.ymlという名前で用意しました。なお、既存のワークフロー名はrubocop.ymlに名前を変更しています。ついでに README の見栄えも良くしてみました（気に入らなければ discard で大丈夫です）。
TODO
main.yml->rubocop.ymlrspec.ymlの作成（Pushトリガーで Rspec を実行）