Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove redundant trailing spaces and newlines #535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KSXGitHub
Copy link
Contributor

No description provided.

@KSXGitHub KSXGitHub requested a review from zkochan May 13, 2024 18:27
Copy link

stackblitz bot commented May 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pnpm-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 6:39pm

@zkochan
Copy link
Member

zkochan commented May 13, 2024

This will likely force me to reapprove all the related localizations in crowdin. So, I don't think it is worth it

@KSXGitHub
Copy link
Contributor Author

Do crowdin translation contains trailing whitespaces?

@KSXGitHub
Copy link
Contributor Author

I just checked out crowdin page for pnpm, and unfortunately, its sources do contain trailing whitespaces.

If there is a way to download crowdin translation, we can run a script to automatically update all the sources to remove trailing whitespaces.

@zkochan
Copy link
Member

zkochan commented May 16, 2024

is there some linting for preventing trailing spaces in the future? maybe remark can be used

@KSXGitHub
Copy link
Contributor Author

KSXGitHub commented May 16, 2024

There are plenty of markdown linters if one searches for it on Google:

But the tool I used to create this PR was a simple Node.js script.

@zkochan
Copy link
Member

zkochan commented May 16, 2024

IMO, the formatting of markdown files in this repo doesn't matter. People can even edit the files in the github web interface. We don't care about the format. So, I'd just recommend to turn off autoformat in the editor for this repo. We can commit a vscode config file if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants