Skip to content

Commit

Permalink
[Feature]: refactor the action naming, Closes #209 (#227)
Browse files Browse the repository at this point in the history
## 🎯 Aim

Solve #209, and to give @Adam-it a PR as B-day present πŸ₯³ 🎈 

## πŸ“· Result


![image](https://github.com/pnp/vscode-viva/assets/35696168/2761ac22-9a27-4a55-8652-f58b1ed9abf7)

## βœ… What was done

- [ ] Didn't removed 'Current' from `CliActions.ts` ==> Don't know if
you want me te remove 'Current' from there too? πŸ€”
- [X] Removed 'Current' in `README.md`
- [X] Removed 'Current' in `tasks-and-actions.md`
- [X] Removed 'Current' in `CommandPanel.ts`

## πŸ”— Related issue

Closes: #209
  • Loading branch information
nicodecleyre authored Apr 23, 2024
1 parent 1c83885 commit d2c3c63
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,13 @@ And for Azure DevOpsπŸ‘‡

[Check out our docs for more details](https://github.com/pnp/vscode-viva/wiki/5.5-Actions#upgrade-project)

- **Validate current project** - Creates a validation .md report against the currently used SPFx version in the project. The action will automatically detect the SPFx version used and will validate if the project is properly set up.
- **Validate project** - Creates a validation .md report against the currently used SPFx version in the project. The action will automatically detect the SPFx version used and will validate if the project is properly set up.

![Upgrade project](./assets/images/validate-project.png)

[Check out our docs for more details](https://github.com/pnp/vscode-viva/wiki/5.5-Actions#validate-current-project)

- **Rename current project** - Forget about manual work and let the extension rename your project and generate a new solution ID.
- **Rename project** - Forget about manual work and let the extension rename your project and generate a new solution ID.

![Rename](./assets/images/rename.png)

Expand Down
4 changes: 2 additions & 2 deletions assets/walkthrough/tasks-and-actions.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ And for Azure DevOpsπŸ‘‡

[Check out our docs for more details](https://github.com/pnp/vscode-viva/wiki/5.5-Actions#upgrade-project)

- **Validate current project** - Creates a validation .md report against the currently used SPFx version in the project. The action will automatically detect the SPFx version used and will validate if the project is properly set up.
- **Validate project** - Creates a validation .md report against the currently used SPFx version in the project. The action will automatically detect the SPFx version used and will validate if the project is properly set up.

![Upgrade project](../images/validate-project.png)

[Check out our docs for more details](https://github.com/pnp/vscode-viva/wiki/5.5-Actions#validate-current-project)

- **Rename current project** - Forget about manual work and let the extension rename your project and generate a new solution ID.
- **Rename project** - Forget about manual work and let the extension rename your project and generate a new solution ID.

![Rename](../images/rename.png)

Expand Down
4 changes: 2 additions & 2 deletions src/panels/CommandPanel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ export class CommandPanel {
private static async actionsTreeView() {
const actionCommands: ActionTreeItem[] = [
new ActionTreeItem('Upgrade project', '', { name: 'arrow-up', custom: false }, undefined, Commands.upgradeProject),
new ActionTreeItem('Validate current project', '', { name: 'check-all', custom: false }, undefined, Commands.validateProject),
new ActionTreeItem('Rename current project', '', { name: 'whole-word', custom: false }, undefined, Commands.renameProject),
new ActionTreeItem('Validate project', '', { name: 'check-all', custom: false }, undefined, Commands.validateProject),
new ActionTreeItem('Rename project', '', { name: 'whole-word', custom: false }, undefined, Commands.renameProject),
new ActionTreeItem('Grant API permissions', '', { name: 'workspace-trusted', custom: false }, undefined, Commands.grantAPIPermissions),
new ActionTreeItem('Deploy project (sppkg)', '', { name: 'cloud-upload', custom: false }, undefined, Commands.deployProject),
new ActionTreeItem('Add new component', '', { name: 'add', custom: false }, undefined, Commands.addToProject),
Expand Down

0 comments on commit d2c3c63

Please sign in to comment.