Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed versioning error in package-solution.json #5294

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

Tanddant
Copy link
Contributor

@Tanddant Tanddant commented Oct 9, 2024

  • New sample
  • Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

As mentioned in #5280 there's a small issue where the version number had gotten trimmed by a digit (probably from copy pasting it from the readme.md)

Node Version

(Use node -v to get the version of Node you used to build this sample)

Node version used: v16

Checklist

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@hugoabernier hugoabernier merged commit bb84e82 into pnp:main Oct 13, 2024
2 checks passed
@hugoabernier
Copy link
Collaborator

Many thanks @Tanddant for your update! Awesome!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants