Skip to content

Commit

Permalink
Merge pull request #3779 from petkir/3777-react-directory
Browse files Browse the repository at this point in the history
  • Loading branch information
hugoabernier authored Jul 13, 2023
2 parents 9135e0a + 285f66a commit 5a37534
Show file tree
Hide file tree
Showing 30 changed files with 58,381 additions and 23,294 deletions.
352 changes: 352 additions & 0 deletions samples/react-directory/.eslintrc.js

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions samples/react-directory/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ node_modules
# Build generated files
dist
lib
release
solution
temp
*.sppkg
.heft

# Coverage directory used by tools like istanbul
coverage
Expand Down
16 changes: 16 additions & 0 deletions samples/react-directory/.npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
!dist
config

gulpfile.js

release
src
temp

tsconfig.json
tslint.json

*.log

.yo-rc.json
.vscode
15 changes: 12 additions & 3 deletions samples/react-directory/.yo-rc.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,22 @@
{
"@microsoft/generator-sharepoint": {
"version": "1.11.0",
"plusBeta": false,
"nodeVersion": "16.13.2",
"sdksVersions": {
"@microsoft/microsoft-graph-client": "3.0.2",
"@microsoft/teams-js": "2.9.1"
},
"version": "1.17.3",
"libraryName": "react-directory",
"libraryId": "5b62bc16-3a71-461d-be2f-16bfcb011e8a",
"environment": "spo",
"packageManager": "npm",
"framework": "react",
"isCreatingSolution": true,
"isDomainIsolated": false,
"componentType": "webpart"
"componentType": "webpart",
"solutionName": "\\",
"solutionShortDescription": "\\ description",
"skipFeatureDeployment": true
}
}
}
5 changes: 3 additions & 2 deletions samples/react-directory/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ Search People from Organization Directory and show live persona card on hover.
| Every SPFx version is only compatible with specific version(s) of Node.js. In order to be able to build this sample, please ensure that the version of Node on your workstation matches one of the versions listed in this section. This sample will not work on a different version of Node.|
|Refer to <https://aka.ms/spfx-matrix> for more information on SPFx compatibility. |

![SPFx 1.11](https://img.shields.io/badge/SPFx-1.11.0-green.svg)
![Node.js v10](https://img.shields.io/badge/Node.js-v10-green.svg)
![SPFx 1.17.3](https://img.shields.io/badge/SPFx-1.17.3-green.svg)
![Node.js v16](https://img.shields.io/badge/Node.js-v16-green.svg)
![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg)
![Does not work with SharePoint 2019](https://img.shields.io/badge/SharePoint%20Server%202019-Incompatible-red.svg "SharePoint Server 2019 requires SPFx 1.4.1 or lower")
![Does not work with SharePoint 2016 (Feature Pack 2)](https://img.shields.io/badge/SharePoint%20Server%202016%20(Feature%20Pack%202)-Incompatible-red.svg "SharePoint Server 2016 Feature Pack 2 requires SPFx 1.1")
Expand Down Expand Up @@ -82,6 +82,7 @@ Version|Date|Comments
3.0.1|March 4 2021|Bugfix 'Sort People by'
3.0.2|Oct 3 2022|Minor styling fixes and people container position
3.0.3|Oct 4 2022|Fix for LivePersonaCard
3.0.4|Jun 20 2023|Upgrade to SPFx 1.17.3

## Minimal Path to Awesome

Expand Down
6 changes: 3 additions & 3 deletions samples/react-directory/assets/sample.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"Search People from Organization Directory and show live persona card on hover."
],
"creationDateTime": "2021-03-04",
"updateDateTime": "2021-03-04",
"updateDateTime": "2023-06-20",
"products": [
"SharePoint"
],
Expand All @@ -20,7 +20,7 @@
},
{
"key": "SPFX-VERSION",
"value": "1.11.0"
"value": "1.17.3"
},
{
"key": "SPFX-TEAMSTAB",
Expand Down Expand Up @@ -117,7 +117,7 @@
},
{
"gitHubAccount": "petkir",
"company": "Cubido Business Solutions GmbH",
"company": "ACP Cubido Digital Solution",
"pictureUrl": "https://github.com/petkir.png",
"name": "Peter Paul Kirschner",
"twitter": "petkir_at"
Expand Down
4 changes: 0 additions & 4 deletions samples/react-directory/config/copy-assets.json

This file was deleted.

14 changes: 7 additions & 7 deletions samples/react-directory/config/deploy-azure-storage.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/deploy-azure-storage.schema.json",
"workingDir": "./temp/deploy/",
"account": "<!-- STORAGE ACCOUNT NAME -->",
"container": "react-directory",
"accessKey": "<!-- ACCESS KEY -->"
}
{
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/deploy-azure-storage.schema.json",
"workingDir": "./release/assets/",
"account": "<!-- STORAGE ACCOUNT NAME -->",
"container": "",
"accessKey": "<!-- ACCESS KEY -->"
}
26 changes: 24 additions & 2 deletions samples/react-directory/config/package-solution.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,32 @@
},
"name": "Search Directory",
"id": "5b62bc16-3a71-461d-be2f-16bfcb011e8a",
"version": "3.0.3.0",
"version": "3.0.4.0",
"includeClientSideAssets": true,
"skipFeatureDeployment": true,
"isDomainIsolated": false
"isDomainIsolated": false,
"metadata": {
"shortDescription": {
"default": "react-directory description"
},
"longDescription": {
"default": "react-directory description"
},
"screenshotPaths": [],
"videoUrl": "",
"categories": []
},
"features": [
{
"title": "react-directory DirectoryWebPart Feature",
"description": "The feature that activates DirectoryWebPart from the react-directory solution.",
"id": "fae479bf-405f-4f80-a086-eea22eff3d6f",
"version": "3.0.4.0",
"componentIds": [
"fae479bf-405f-4f80-a086-eea22eff3d6f"
]
}
]
},
"paths": {
"zippedPackage": "solution/react-directory.sppkg"
Expand Down
3 changes: 3 additions & 0 deletions samples/react-directory/config/sass.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/core-build/sass.schema.json"
}
9 changes: 3 additions & 6 deletions samples/react-directory/config/serve.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/core-build/serve.schema.json",
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/spfx-serve.schema.json",
"port": 4321,
"https": true,
"initialPage": "https://localhost:5432/workbench",
"api": {
"port": 5432,
"entryPath": "node_modules/@microsoft/sp-webpart-workbench/lib/api/"
}
"initialPage": "https://{tenantDomain}/_layouts/workbench.aspx",

}
25 changes: 8 additions & 17 deletions samples/react-directory/gulpfile.js
Original file line number Diff line number Diff line change
@@ -1,29 +1,20 @@
'use strict';

// check if gulp dist was called
if (process.argv.indexOf('dist') !== -1) {
// add ship options to command call
process.argv.push('--ship');
}

const path = require('path');
const gulp = require('gulp');
const build = require('@microsoft/sp-build-web');
const gulpSequence = require('gulp-sequence');

build.addSuppression(`Warning - [sass] The local CSS class 'ms-Grid' is not camelCase and will not be type-safe.`);

// Create clean distrubution package
gulp.task('dist', gulpSequence('clean', 'bundle', 'package-solution'));
// Create clean development package
gulp.task('dev', gulpSequence('clean', 'bundle', 'package-solution'));
var getTasks = build.rig.getTasks;
build.rig.getTasks = function () {
var result = getTasks.call(build.rig);

result.set('serve', result.get('serve-deprecated'));

return result;
};


/**
* Custom Framework Specific gulp tasks
*/


build.initialize(gulp);

build.initialize(require('gulp'));
Loading

0 comments on commit 5a37534

Please sign in to comment.