Skip to content

Commit

Permalink
Merge pull request #127 from SharePoint/dev
Browse files Browse the repository at this point in the history
Merge for v1.8.0
  • Loading branch information
estruyf authored Sep 12, 2018
2 parents 6dfc483 + 2f74bdb commit fbdbbc6
Show file tree
Hide file tree
Showing 30 changed files with 463 additions and 186 deletions.
23 changes: 23 additions & 0 deletions CHANGELOG.JSON
Original file line number Diff line number Diff line change
@@ -1,5 +1,28 @@
{
"versions": [
{
"version": "1.8.0",
"changes": {
"new": [],
"enhancements": [
"`PeoplePicker`: Specify to hide or show the users/groups which are hidden in the UI [#122](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/122)",
"`WebPartTitle`: changing font-sizes on different resolutions [#114](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/114)",
"`WebPartTitle`: Added accessibility tags for web part title [#121](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/121)",
"`ListView`: Resizable columns - introduced a `isResizable` property [#119](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/119)",
"`FieldNameRenderer` double click support added [#116](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/116)",
"`TaxonomyPicker`: table markup changed to DIV [#113](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/113)",
"`PeoplePicker`: ability to specify the source site to load users from [#110](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/110)",
"`TaxonomyPicker`: Disable the terms which are set as deprecated or unavailable for tagging [#109](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/109)",
"`PeoplePicker`: Specify principle type to retrieve (users, groups, ...) [#94](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/94)"
],
"fixes": [
"`FieldLookupRenderer`: Fixed URL querystring params [#126](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/126)",
"`IFrameDialog`: dialog width is not correct in IE11 [#118](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/118)",
"`PeoplePicker`: fix freezes when typing in search values [#117](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/117)"
]
},
"contributions": ["[Thomas Lamb](https://github.com/ThomasLamb)", "[Joel Rodrigues](https://github.com/joelfmrodrigues)", "[Mikael Svenson](https://github.com/wobba)", "[Alex Terentiev](https://github.com/AJIXuMuK)"]
},
{
"version": "1.7.0",
"changes": {
Expand Down
20 changes: 20 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,25 @@
# Releases

## 1.8.0

**Enhancements**

- `PeoplePicker`: Specify to hide or show the users/groups which are hidden in the UI [#122](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/122)
- `WebPartTitle`: changing font-sizes on different resolutions [#114](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/114)
- `WebPartTitle`: Added accessibility tags for web part title [#121](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/121)
- `ListView`: Resizable columns - introduced a `isResizable` property [#119](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/119)
- `FieldNameRenderer` double click support added [#116](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/116)
- `TaxonomyPicker`: table markup changed to DIV [#113](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/113)
- `PeoplePicker`: ability to specify the source site to load users from [#110](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/110)
- `TaxonomyPicker`: Disable the terms which are set as deprecated or unavailable for tagging [#109](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/109)
- `PeoplePicker`: Specify principle type to retrieve (users, groups, ...) [#94](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/94)

**Fixes**

- `FieldLookupRenderer`: Fixed URL querystring params [#126](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/126)
- `IFrameDialog`: dialog width is not correct in IE11 [#118](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/118)
- `PeoplePicker`: fix freezes when typing in search values [#117](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/117)

## 1.7.0

**Enhancements**
Expand Down
20 changes: 20 additions & 0 deletions docs/documentation/docs/about/release-notes.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,25 @@
# Releases

## 1.8.0

**Enhancements**

- `PeoplePicker`: Specify to hide or show the users/groups which are hidden in the UI [#122](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/122)
- `WebPartTitle`: changing font-sizes on different resolutions [#114](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/114)
- `WebPartTitle`: Added accessibility tags for web part title [#121](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/121)
- `ListView`: Resizable columns - introduced a `isResizable` property [#119](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/119)
- `FieldNameRenderer` double click support added [#116](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/116)
- `TaxonomyPicker`: table markup changed to DIV [#113](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/113)
- `PeoplePicker`: ability to specify the source site to load users from [#110](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/110)
- `TaxonomyPicker`: Disable the terms which are set as deprecated or unavailable for tagging [#109](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/109)
- `PeoplePicker`: Specify principle type to retrieve (users, groups, ...) [#94](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/94)

**Fixes**

- `FieldLookupRenderer`: Fixed URL querystring params [#126](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/126)
- `IFrameDialog`: dialog width is not correct in IE11 [#118](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/118)
- `PeoplePicker`: fix freezes when typing in search values [#117](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/117)

## 1.7.0

**Enhancements**
Expand Down
1 change: 1 addition & 0 deletions docs/documentation/docs/assets/pnp-spfx-controls.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion docs/documentation/docs/controls/ListView.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const groupByFields: IGrouping[] = [
```

!!! note "Extend ListView with a ContextualMenu"
To extend the `ListView` control with a [ContextualMenu](https://developer.microsoft.com/en-us/fabric#/components/contextualmenu) refer to [ListView.ContextualMenu](./ListView.ContextualMenu).
To extend the `ListView` control with a [ContextualMenu](https://developer.microsoft.com/en-us/fabric#/components/contextualmenu) refer to [ListView.ContextualMenu](./ListView.ContextualMenu.md).

## Implementation

Expand All @@ -82,6 +82,7 @@ The `IViewField` has the following implementation:
| sorting | boolean | no | Specify if you want to enable sorting for the current field. |
| maxWidth | number | no | Specify the minimum width of the column. |
| maxWidth | number | no | Specify the maximum width of the column. |
| isResizable | boolean | no | Determines if the column can be resized. |
| render | function | no | Override how the field has to get rendered. |

The `IGrouping` has the following implementation:
Expand Down
19 changes: 17 additions & 2 deletions docs/documentation/docs/controls/PeoplePicker.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ This control renders a People picker field which can be used to select one or mo
- Import the following modules to your component:

```typescript
import { PeoplePicker } from "@pnp/spfx-controls-react/lib/PeoplePicker";
import { PeoplePicker, PrincipalType } from "@pnp/spfx-controls-react/lib/PeoplePicker";
```

- Use the `PeoplePicker` control in your code as follows:
Expand All @@ -35,7 +35,9 @@ import { PeoplePicker } from "@pnp/spfx-controls-react/lib/PeoplePicker";
showtooltip={true}
isRequired={true}
disabled={true}
selectedItems={this._getPeoplePickerItems} />
selectedItems={this._getPeoplePickerItems}
showHiddenInUI={false}
principleTypes={[PrincipalType.User]} />
```

- With the `selectedItems` property you can get the selected People in the Peoplepicker :
Expand Down Expand Up @@ -67,6 +69,19 @@ The People picker control can be configured with the following properties:
| peoplePickerWPclassName | string | no | applies custom styling to the people picker element |
| peoplePickerCntrlclassName | string | no | applies custom styling to the people picker control only |
| defaultSelectedUsers | string[] | no | Default selected user emails |
| webAbsoluteUrl | string | no | Specify the site URL on which you want to perform the user query call. Default is the current site URL. |
| showHiddenInUI | boolean | no | Show users which are hidden from the UI. By default these users/groups hidden for the UI will not be shown. |
| principleTypes | PrincipleType[] | no | Define which type of data you want to retrieve: User, SharePoint groups, Security groups. Multiple are possible. |

Enum `PrincipalType`

The `PrincipalType` enum can be used to specify the types of information you want to query: User, Security groups, and/or SharePoint groups.

| Name |
| ---- |
| User |
| DistributionList |
| SecurityGroup |
| SharePointGroup |

![](https://telemetry.sharepointpnp.com/sp-dev-fx-controls-react/wiki/controls/PeoplePicker)
6 changes: 3 additions & 3 deletions docs/documentation/docs/controls/fields/FieldNameRenderer.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ The FieldNameRenderer component can be configured with the following properties:
| isLink | boolean | yes | True if the name should be rendered as a link. |
| isNew | boolean | no | True if the document is new. |
| filePath | string | no | Path to the document. |
| hasPreview | boolean | no | True if the document has preview (true by default) |
| onClick | (args: INameClickEventArgs) => {} | no | Custom handler for link click. If not set link click will lead to rendering document preview. |

| hasPreview | boolean | no | True if the document has preview and link href should be constructed to display the preview (instead of direct document's link). The flag works only if `onClick` property is NOT defined. |
| onClick | (args: INameClickEventArgs) => {} | no | Custom handler for link click. If not set link click will lead to rendering document preview. Works if `isLink` is set to `true` |
| onDoubleClick | (args: INameClickEventArgs) => {} | no | Custom handler for link double click. If not set link If not set link will use OOTB behavior. Works if `isLink` is set to `true` |

![](https://telemetry.sharepointpnp.com/sp-dev-fx-controls-react/wiki/controls/fields/FieldNameRenderer)

32 changes: 32 additions & 0 deletions docs/documentation/docs/css/extra.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
.md-logo {
height: 32px;
width: 150px;
}

.md-logo img {
width: 100% !important;
height: auto !important;
margin-top: -0.25em;
}

.md-header{
height: 75px;
}

.md-container{
padding-top: 70px;
}

.md-sidebar[data-md-state="lock"]{
padding-top: 75px;
}

.md-footer {
margin-top: 5em;
}

@media only screen and (max-width: 76.1875em) {
.md-nav--primary .md-nav__title--site .md-nav__button {
width: 150px;
}
}
8 changes: 5 additions & 3 deletions docs/documentation/mkdocs.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
site_name: SharePoint Framework React Controls
pages:
site_name: '@pnp/spfx-controls-react'
nav:
- Home: 'index.md'
- Controls:
- FileTypeIcon: 'controls/FileTypeIcon.md'
Expand Down Expand Up @@ -34,9 +34,11 @@ theme:
name: 'material'
palette:
primary: 'blue'
logo: 'assets/sharepoint.png'
logo: 'assets/pnp-spfx-controls.svg'
feature:
tabs: true
extra_css:
- 'css/extra.css'
markdown_extensions:
- admonition
- codehilite:
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@pnp/spfx-controls-react",
"description": "Reusable React controls for SharePoint Framework solutions",
"version": "1.7.0",
"version": "1.8.0",
"engines": {
"node": ">=0.10.0"
},
Expand All @@ -21,7 +21,8 @@
"@pnp/odata": "^1.0.1",
"@pnp/sp": "^1.0.1",
"@pnp/telemetry-js": "1.0.0",
"lodash": "^4.17.4"
"lodash": "^4.17.4",
"office-ui-fabric-react": "~5.122.0"
},
"devDependencies": {
"@microsoft/decorators": "~1.3.0",
Expand Down
2 changes: 1 addition & 1 deletion src/common/telemetry/version.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const version: string = "1.7.0";
export const version: string = "1.8.0";
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export class FieldLookupRenderer extends React.Component<IFieldLookupRendererPro
//
if (this.state.dispFormUrl) {
this.setState({
lookupDispFormUrl: `${this.state.dispFormUrl}&ID=${lookup.lookupId}&RootFolder=*&IsDlg=1`,
lookupDispFormUrl: `${this.state.dispFormUrl}?ID=${lookup.lookupId}&RootFolder=*&IsDlg=1`,
hideDialog: false
});
}
Expand All @@ -147,7 +147,7 @@ export class FieldLookupRenderer extends React.Component<IFieldLookupRendererPro

return {
dispFormUrl: dispFormUrl,
lookupDispFormUrl: `${dispFormUrl}&ID=${lookup.lookupId}&RootFolder=*&IsDlg=1`
lookupDispFormUrl: `${dispFormUrl}?ID=${lookup.lookupId}&RootFolder=*&IsDlg=1`
};
});
});
Expand Down
Loading

0 comments on commit fbdbbc6

Please sign in to comment.