Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3744 and #3753 #3745

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Closes #3744 and #3753 #3745

merged 6 commits into from
Feb 16, 2024

Conversation

reshmee011
Copy link
Contributor

Type

  • Bug Fix

Related Issues?

Fixes #3744

What is in this Pull Request ?

updated permissions in file src\Commands\Resources\O365ManagementPermissions.json to include these two

{
"adminConsentDescription": "Allows the application to read service health information for your organization.",
"adminConsentDisplayName": "Read activity reports for your organization",
"id": "b3b78c39-cb1d-4d17-820a-25d9196a800e",
"isEnabled": true,
"isAdmin": true,
"consentDescription": "Allows the application to read service health information for your organization.",
"consentDisplayName": "Read service health information for your organization",
"value": "ActivityReports.Read"
},
{
"adminConsentDescription": "Allows the application to read threat intelligence data for your organization",
"adminConsentDisplayName": "Read threat intelligence data for your organization",
"id": "17f1c501-83cd-414c-9064-cd10f7aef836",
"isEnabled": true,
"isAdmin": true,
"consentDescription": "Allows the application to read threat intelligence data for your organization",
"consentDisplayName": "Read threat intelligence data for your organization",
"value": "ThreatIntelligence.Read"
}

Guidance

@gautamdsheth
Copy link
Collaborator

@reshmee011 - should we update the cmdlet permissions as well for this ? Also, I think we need to mention it in the docs as well.

@reshmee011
Copy link
Contributor Author

@gautamdsheth , it's quite interesting as I could not find any documentation on these two extra permissions from the o365 management APIs and they can't be added to the app registration from the UI except updating the manifest json to include these extra permissions.
Where shall I mention it in the docs? It is worth mentioning it.
image

@gautamdsheth
Copy link
Collaborator

@reshmee011 - I meant in the cmdlet , we have requiredminimalpermissions attribute, maybe we can add it there ?

In the cmdlet docs as well something similar maybe ?

@reshmee011
Copy link
Contributor Author

@gautamdsheth : I have added the permissions to the cmd and doc. At least adding these extra permissions helps with the unauthorized bug I was facing, hope it will be the same for others.

@reshmee011 reshmee011 changed the title Closes #3744 Closes #3744 and #3753 Feb 16, 2024
@gautamdsheth
Copy link
Collaborator

Awesome, thanks @reshmee011 merged it !!

@gautamdsheth gautamdsheth merged commit 907ba82 into pnp:dev Feb 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Get-PnPUnifiedAuditLog -ContentType DLP throwing 401 error
2 participants