Enhances command spo list remove #6378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, we'll try to review it ASAP! |
milanholemans
requested changes
Oct 15, 2024
|
I have done rebase to main and added the commit. Is it fine or do I need to resolve anything from my end. Please guide me |
|
@ktskumar seems like something went horribly wrong while rebasing with the latest main. Could you have a look at it, please? |
milanholemans
approved these changes
Oct 17, 2024
| promptIssued = true; | ||
| return Promise.resolve(false); | ||
| //return Promise.resolve(false); |
There was a problem hiding this comment.
Let's remove comments
| sinon.stub(request, 'post').callsFake(async (opts) => { | ||
| requests.push(opts); | ||
| if (opts.url === `${webUrl}/_api/web/lists/GetByTitle('${listTitle}')/recycle`) { | ||
| return 'Correct URL'; |
There was a problem hiding this comment.
This API doesn't return any result. Let's also return nothing in our stub.
Comment on lines
+161
to
+165
| requests.forEach(r => { | ||
| if (r.url === `${webUrl}/_api/web/lists/GetByTitle('${listTitle}')/recycle`) { | ||
| correctRequestIssued = true; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Instead of doing this, let's use assert(postStub.calledOnce). This ensures that the request was called once and didn't throw an error.
|
Merged manually, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6270
In this PR, i have added a recycle option to
spo list removecommand