Adds new sample "find-obsolete-m365-groups" #6250

tmaestrini · 2024-08-14T21:06:45Z

This script is based on the original article written by Tony Redmond and was requested a long time ago in #2475.
It generates a report of all M365 groups that are possibly obsolete.

Closes #2475

…#2475

milanholemans · 2024-08-14T21:14:41Z

Cool! Thank you @tmaestrini! We'll try to review it ASAP!

milanholemans

Really nice script! I saw a few small things we should take a look at. Also, on my (small) tenant, the script seems to be crashing every time.

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/assets/sample.json

milanholemans

Did another review and zoomed in a bit on the error I was getting @tmaestrini.

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx

tmaestrini · 2024-09-09T12:20:03Z

Did a bunch of changes, @milanholemans – thanks for your review. 🙏 I've really appreciated it.

milanholemans · 2024-09-09T13:27:45Z

Did a bunch of changes, @milanholemans – thanks for your review. 🙏 I've really appreciated it.

When ready, you can hit the "ready for review" at the bottom of the page, which I just did for you :)

tmaestrini · 2024-09-18T20:37:54Z

Hey @milanholemans, sorry for my confusion on my last commit (#b2ae47f). I wanted to open a new PR related to #6272.

tmaestrini · 2024-09-19T20:06:38Z

@milanholemans This one still waits for a review / approval.

milanholemans

Hi @tmaestrini, I was able to do another review and made some additional remarks. Also the script is still failing on my tenant, so let's try to get that fixed first.

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx

milanholemans · 2024-09-20T19:08:38Z

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx

+    $guests = $users | Where-Object { $_.id -in $Script:Guests.id }
+
+    # Modify the $members list to only contain users that are not in the $owners list
+    $members = Compare-Object $members $owners -PassThru


This piece of code is still failing for all company groups which have no owners and no members.

You're absolutely right. This would be the case, when every group member has left the company. In this case, any comparison would be obsolete.

As mentioned in the previous review. When you have an all company group, it doesn't have any owners or members.

@milanholemans That's why I've implemented this on line 170:

if($null -ne $owners -and $null -ne $members) { $members = Compare-Object $members $owners -PassThru }

Doesn't it show up in the code?

The last time I reviewed it wasn't there. I'll recheck in my next review.

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx

… console with unnecessary output

…s obsolete

tmaestrini · 2024-09-25T23:27:15Z

Hey @milanholemans, did a bunch of updates… 😄 Hopefully the script is not failing anymore on your tenant.
Tell me what you think. Have a good night! 😄

tmaestrini · 2024-10-15T05:50:10Z

Any news on this? Do you want me to change anything?

milanholemans · 2024-10-15T07:25:26Z

Hi @tmaestrini will try to do another review soon. Due to lack of time this has not happened yet.

milanholemans

Seems like I'm still struggling to make the script work on my tenant. Let's have another look at it.

milanholemans · 2024-10-15T21:37:09Z

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx

+    $tStamp = (Get-Date).ToString("yyyy-MM-dd HH:mm:ss")
+    if ($TestPath -ne $true) {
+      New-Item -ItemType directory -Path $Script:Path | Out-Null
+      Write-Host "Will create file in $($Script:Path): M365GroupsReport-$tStamp.csv" -ForegroundColor Yellow


I'm getting an error:

The filename, directory name, or volume label syntax is incorrect. : 'C:\Report\M365GroupsReport-2024-10-15 23:32:22.csv'

Obviously, colons are not supported as characters in Windows. Let's strip the file name from illegal characters.

milanholemans · 2024-10-15T21:40:14Z

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx

+
+    $spoSite = $Script:TeamSites | Where-Object { $_.GroupId -eq "/Guid($($Group.Reference.id))/" }
+    $spoWeb = m365 spo web get --url $spoSite.Url | ConvertFrom-Json
+    if ($spoWeb.LastItemUserModifiedDate -lt $WarningDate) {


As discussed before, let's remove the spo web get request and just check the date on the spoSite object to avoid permission issues.

milanholemans · 2024-10-15T21:55:58Z

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx

+
+    if ($owners.Count -eq 0) {
+      Write-Host "  → potentially obsolete (abandoned group: no owner)" -ForegroundColor Yellow
+      $reason = "Low user count"


Suggested change

$reason = "Low user count"

$reason = "Low owner count"

milanholemans · 2024-10-15T21:59:05Z

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx

+      return
+    }
+
+    if ($owners.Count -le 1 -and ($members.Count + $guests.Count) -eq 0) {


Does it matter whether there's only 1 owner? I think every group without a member has some problems no? Let's also personalize the reasons, right now we're always logging "low user count".

milanholemans · 2024-10-15T22:09:26Z

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx

+    try {
+      $Global:ObsoleteGroups.Add($Group.Reference.id, $Group)
+    }
+    catch { Write-Information "Group was already added to the list of potentially obsolete groups" }


Suggested change

catch { Write-Information "Group was already added to the list of potentially obsolete groups" }

catch { }

Add new sample to find obsolete m365 groups in the tenant. Closes pnp…

b150ee4

…#2475

tmaestrini changed the title ~~Adds new sample find-obsolete-m365-groups in the tenant~~ Adds new sample "find-obsolete-m365-groups" Aug 14, 2024

milanholemans added the pr-sample label Aug 14, 2024

add preview image to assets

c3c96bb

milanholemans self-assigned this Aug 24, 2024

milanholemans requested changes Aug 24, 2024

View reviewed changes

milanholemans marked this pull request as draft August 24, 2024 18:39

fix typos and change several minor implementations due to readabiltiy

9643937

milanholemans marked this pull request as ready for review August 30, 2024 22:29

milanholemans requested changes Sep 4, 2024

View reviewed changes

milanholemans marked this pull request as draft September 4, 2024 18:07

change implementation after rewiew

793b05b

tmaestrini commented Sep 9, 2024

View reviewed changes

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx Outdated Show resolved Hide resolved

tmaestrini commented Sep 9, 2024

View reviewed changes

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx Outdated Show resolved Hide resolved

tmaestrini commented Sep 9, 2024

View reviewed changes

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx Show resolved Hide resolved

tmaestrini commented Sep 9, 2024

View reviewed changes

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx Show resolved Hide resolved

tmaestrini commented Sep 9, 2024

View reviewed changes

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx Outdated Show resolved Hide resolved

tmaestrini commented Sep 9, 2024

View reviewed changes

docs/docs/sample-scripts/entra/find-obsolete-m365-groups/index.mdx Show resolved Hide resolved

milanholemans marked this pull request as ready for review September 9, 2024 13:25

Merge branch 'pnp:main' into main

b2ae47f

tmaestrini force-pushed the main branch from e357b82 to b2ae47f Compare September 18, 2024 20:30

tmaestrini mentioned this pull request Sep 18, 2024

Remove obsolete example #6272

Closed

milanholemans requested changes Sep 20, 2024

View reviewed changes

milanholemans marked this pull request as draft September 20, 2024 19:11

change console output to make the output path more precise for the user

34bdeaa

change retrieval of owners and members to increase script performance

bf41310

tmaestrini mentioned this pull request Sep 23, 2024

Bug report: Retrieving members for M365 group via entra m365group user list leads to unexpected result #6382

Closed

Tobias Maestrini added 8 commits September 25, 2024 23:35

fix error related to comparison in case that group is empty

c8ca5af

fix handling of groups with 0 or only 1 owner

2b723ff

change logging behavior (reverted) in order to avoid overflooding the…

bc31a5b

… console with unnecessary output

change member retrieval by excluding guests from the members' list

0c3779d

change retrieval of groups and procedure to check whether the group i…

1aadf57

…s obsolete

add additional information to exported object (group conversation infos)

e43a560

change sample preview image

310bd82

fix formatting

692a8ad

tmaestrini marked this pull request as ready for review September 25, 2024 23:27

tmaestrini added 2 commits September 29, 2024 00:46

Merge branch 'pnp:main' into main

988904f

Merge branch 'pnp:main' into main

329ef17

milanholemans requested changes Oct 15, 2024

View reviewed changes

milanholemans marked this pull request as draft October 15, 2024 22:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds new sample "find-obsolete-m365-groups" #6250

Adds new sample "find-obsolete-m365-groups" #6250

tmaestrini commented Aug 14, 2024

milanholemans commented Aug 14, 2024

milanholemans left a comment

milanholemans left a comment

tmaestrini commented Sep 9, 2024

milanholemans commented Sep 9, 2024 •

edited

Loading

tmaestrini commented Sep 18, 2024

tmaestrini commented Sep 19, 2024 •

edited

Loading

milanholemans left a comment

milanholemans Sep 20, 2024

tmaestrini Sep 25, 2024

milanholemans Sep 28, 2024

tmaestrini Sep 28, 2024

milanholemans Sep 28, 2024

tmaestrini commented Sep 25, 2024

tmaestrini commented Oct 15, 2024 •

edited

Loading

milanholemans commented Oct 15, 2024

milanholemans left a comment

milanholemans Oct 15, 2024

milanholemans Oct 15, 2024

milanholemans Oct 15, 2024

milanholemans Oct 15, 2024

milanholemans Oct 15, 2024

	catch { Write-Information "Group was already added to the list of potentially obsolete groups" }
	catch { }

Adds new sample "find-obsolete-m365-groups" #6250

Are you sure you want to change the base?

Adds new sample "find-obsolete-m365-groups" #6250

Conversation

tmaestrini commented Aug 14, 2024

milanholemans commented Aug 14, 2024

milanholemans left a comment

Choose a reason for hiding this comment

milanholemans left a comment

Choose a reason for hiding this comment

tmaestrini commented Sep 9, 2024

milanholemans commented Sep 9, 2024 • edited Loading

tmaestrini commented Sep 18, 2024

tmaestrini commented Sep 19, 2024 • edited Loading

milanholemans left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmaestrini commented Sep 25, 2024

tmaestrini commented Oct 15, 2024 • edited Loading

milanholemans commented Oct 15, 2024

milanholemans left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

milanholemans commented Sep 9, 2024 •

edited

Loading

tmaestrini commented Sep 19, 2024 •

edited

Loading

tmaestrini commented Oct 15, 2024 •

edited

Loading