Adds new command `site membership list` Closes #5980 #6087

mkm17 · 2024-06-10T06:09:35Z

Adds new command site membership list Closes #5980

milanholemans · 2024-06-10T08:09:30Z

Thank you @mkm17, we'll try to review it ASAP!

mkm17 · 2024-07-03T20:35:24Z

Here, the same change mentioned in this code review will be applied: using spo.getSiteId() to get the site ID in admin mode.

Jwaegebaert · 2024-07-09T11:06:30Z

Hey @mkm17, there seem to be some conflicts. Could you take a look at them?

milanholemans

Cool command @mkm17! Right now it's a bit clearer to me what the difference is between the spo web get variant.
Anyway, could you have a look at the remarks I made?

src/m365/spo/commands.ts

src/m365/spo/commands/tenant/tenant-site-membership-list.ts

docs/docs/cmd/spo/tenant/tenant-site-membership-list.mdx

src/m365/spo/commands/tenant/tenant-site-membership-list.spec.ts

mkm17 · 2024-08-11T15:53:13Z

Thank you @milanholemans for the review, I have made the requested changes, and added some comments :)

milanholemans

We're making good progress. Let's change a few more things before we continue.

src/m365/spo/commands/tenant/tenant-site-membership-list.ts

docs/docs/cmd/spo/tenant/tenant-site-membership-list.mdx

src/m365/spo/commands/tenant/tenant-site-membership-list.ts

src/m365/spo/commands/tenant/tenant-site-membership-list.spec.ts

mkm17 · 2024-09-06T15:21:46Z

Hi @milanholemans, apologies for the delay in introducing the changes. I won't have access to a PC this weekend, but I’ll aim to send the updates at the beginning of next week.

milanholemans · 2024-09-06T15:28:16Z

Hi @milanholemans, apologies for the delay in introducing the changes. I won't have access to a PC this weekend, but I’ll aim to send the updates at the beginning of next week.

Thanks for the update @mkm17, take your time 😊

milanholemans

I was able to do another review. Let's change a few more things.

src/m365/spo/commands/tenant/tenant-site-membership-list.ts

src/utils/spo.ts

src/m365/spo/commands/tenant/tenant-site-membership-list.ts

src/m365/spo/commands/tenant/tenant-site-membership-list.spec.ts

docs/docs/cmd/spo/tenant/tenant-site-membership-list.mdx

milanholemans · 2024-10-15T21:10:00Z

Hi @mkm17, Could you please resolve the conflicts and rebase them with the latest main?

mkm17 · 2024-10-16T13:37:12Z

Hi @mkm17, Could you please resolve the conflicts and rebase them with the latest main?

@milanholemans ok done.

milanholemans

Looks ready to be shipped!

milanholemans · 2024-10-16T22:07:48Z

src/m365/spo/commands/tenant/tenant-site-membership-list.spec.ts

+      throw 'Invalid request';
+    });
+
+    sinon.stub(spo, 'getSiteAdminPropertiesByUrl').resolves({ SiteId: siteId } as any);


Since we have to use this in almost every test, let's move it to the before hook so we avoid repetition.

milanholemans · 2024-10-16T22:21:48Z

src/m365/spo/commands/tenant/tenant-site-membership-list.ts

+  }
+
+  public get description(): string {
+    return `Retrieve information about default site groups' membership`;


Let's make the same edit in the docs.

Suggested change

return `Retrieve information about default site groups' membership`;

return `Retrieves information about default site groups' membership`;

@milanholemans, Ok I have changed these last two things. Thanks once again!

milanholemans · 2024-10-17T22:14:08Z

Merged manually, thanks for the new command!

mkm17 force-pushed the issues/5980_get_site_membership_list branch 2 times, most recently from f5d3dd8 to cdddadf Compare June 10, 2024 06:22

mkm17 force-pushed the issues/5980_get_site_membership_list branch from cdddadf to 38f1b08 Compare June 15, 2024 08:19

milanholemans marked this pull request as draft July 9, 2024 11:18

mkm17 force-pushed the issues/5980_get_site_membership_list branch from 38f1b08 to bc2e96e Compare July 10, 2024 16:11

mkm17 marked this pull request as ready for review July 10, 2024 19:51

mkm17 marked this pull request as draft July 28, 2024 14:06

mkm17 force-pushed the issues/5980_get_site_membership_list branch 2 times, most recently from 5066cf0 to f05b5a8 Compare July 28, 2024 15:20

mkm17 marked this pull request as ready for review July 28, 2024 15:24

milanholemans self-assigned this Aug 3, 2024

milanholemans requested changes Aug 4, 2024

View reviewed changes

milanholemans marked this pull request as draft August 4, 2024 00:21

mkm17 force-pushed the issues/5980_get_site_membership_list branch from f05b5a8 to 3757bba Compare August 11, 2024 15:47

mkm17 marked this pull request as ready for review August 11, 2024 15:52

mkm17 force-pushed the issues/5980_get_site_membership_list branch from 3757bba to ae6887f Compare August 11, 2024 17:20

milanholemans requested changes Aug 15, 2024

View reviewed changes

milanholemans marked this pull request as draft August 15, 2024 11:57

mkm17 force-pushed the issues/5980_get_site_membership_list branch 2 times, most recently from 42e296c to d6694bc Compare September 12, 2024 17:05

mkm17 marked this pull request as ready for review September 12, 2024 17:10

milanholemans requested changes Sep 20, 2024

View reviewed changes

milanholemans marked this pull request as draft September 20, 2024 21:02

mkm17 force-pushed the issues/5980_get_site_membership_list branch from d6694bc to 23fb121 Compare September 25, 2024 21:52

mkm17 marked this pull request as ready for review September 26, 2024 13:46

milanholemans marked this pull request as draft October 15, 2024 21:10

mkm17 force-pushed the issues/5980_get_site_membership_list branch 2 times, most recently from 9938294 to cedabf9 Compare October 16, 2024 13:32

mkm17 marked this pull request as ready for review October 16, 2024 13:37

milanholemans approved these changes Oct 16, 2024

View reviewed changes

Adds tenant site membership list command Closes pnp#5980

0df6d49

mkm17 force-pushed the issues/5980_get_site_membership_list branch from cedabf9 to 0df6d49 Compare October 17, 2024 20:39

milanholemans added the pr-merged label Oct 17, 2024

milanholemans closed this Oct 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds new command `site membership list` Closes #5980 #6087

Adds new command `site membership list` Closes #5980 #6087

mkm17 commented Jun 10, 2024

milanholemans commented Jun 10, 2024

mkm17 commented Jul 3, 2024

Jwaegebaert commented Jul 9, 2024

milanholemans left a comment

mkm17 commented Aug 11, 2024

milanholemans left a comment

mkm17 commented Sep 6, 2024

milanholemans commented Sep 6, 2024

milanholemans left a comment

milanholemans commented Oct 15, 2024

mkm17 commented Oct 16, 2024

milanholemans left a comment

milanholemans Oct 16, 2024

milanholemans Oct 16, 2024

mkm17 Oct 17, 2024

milanholemans commented Oct 17, 2024

	return `Retrieve information about default site groups' membership`;
	return `Retrieves information about default site groups' membership`;

Adds new command site membership list Closes #5980 #6087

Adds new command site membership list Closes #5980 #6087

Conversation

mkm17 commented Jun 10, 2024

milanholemans commented Jun 10, 2024

mkm17 commented Jul 3, 2024

Jwaegebaert commented Jul 9, 2024

milanholemans left a comment

Choose a reason for hiding this comment

mkm17 commented Aug 11, 2024

milanholemans left a comment

Choose a reason for hiding this comment

mkm17 commented Sep 6, 2024

milanholemans commented Sep 6, 2024

milanholemans left a comment

Choose a reason for hiding this comment

milanholemans commented Oct 15, 2024

mkm17 commented Oct 16, 2024

milanholemans left a comment

Choose a reason for hiding this comment

milanholemans Oct 16, 2024

Choose a reason for hiding this comment

milanholemans Oct 16, 2024

Choose a reason for hiding this comment

mkm17 Oct 17, 2024

Choose a reason for hiding this comment

milanholemans commented Oct 17, 2024

Adds new command `site membership list` Closes #5980 #6087

Adds new command `site membership list` Closes #5980 #6087