Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'spo listitem attachment remove' command. Closes #5220 #5351

Closed
wants to merge 6 commits into from

Conversation

nanddeepn
Copy link
Contributor

Adds spo listitem attachment remove command. Closes #5220

@Adam-it
Copy link
Contributor

Adam-it commented Jul 26, 2023

Thank you for another awesome PR. We will review it ASAP

Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nanddeepn, would you mind updating your PR to utilize ESM? Here's a breakdown of the new changes:

@Jwaegebaert Jwaegebaert self-assigned this Sep 3, 2023
@Jwaegebaert Jwaegebaert marked this pull request as draft September 3, 2023 16:28
@nanddeepn nanddeepn marked this pull request as ready for review September 4, 2023 14:57
Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @nanddeepn, I've left a few comments you can take a look at

@Jwaegebaert Jwaegebaert marked this pull request as draft September 8, 2023 19:13
@nanddeepn nanddeepn marked this pull request as ready for review September 10, 2023 10:53
Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @nanddeepn! Found one small change but changed that myself during the merging process.

@nanddeepn nanddeepn deleted the issue-5220 branch September 24, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: spo listitem attachment remove
3 participants