-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename options #4467
Comments
Hi @milanholemans, I think in this case we might add a |
Ur right, seems like I was a bit too fast here. |
Revived this issue because I found some other options that are not consistent/don't match our naming convention. |
I think renaming I'd say: rename I'd personally keep Other opinions on this? |
This is one of the few places where we use objectId instead of userId or id. According to me, objectId is not much clearer than just id. |
Well, it's how it is called in Azure AD. But I agree for a user it might be clearer to use id, as we're oftentimes referring to it as userId. |
I would prefer |
Does as user in AAD have another ID than the objectId (which would be the same as the user ID)? |
According to me, AAD user ID is the same as objectId. Just a different name that is only used in AAD on the user profile. |
If they're the same, I suggest we use |
Opening this up as we are releasing v7 after the summer holidays. Warmly recommended for your contribution. 🎉 |
@pnp/cli-for-microsoft-365-maintainers seems like we have 26 flow & pa commands that use |
Hi @milanholemans, I think I'd favor |
Me too, looking at PS commands, it seems like they are using |
I don't have a clear preference as long as it is consistent. The pac cli uses |
It does not seem very consistent, as it does use I think |
Guess it's semantics, for envs they allow providing the url so it wouldn't make sense there. |
Good catch @milanholemans, let's streamline this. I'm also fan of using |
All right I'll add the commands that are using |
This issue seems like an excellent opportunity to become familiar with a lot of commands and script samples. Can I work on it? |
Sure @Saurabh7019! Thanks! |
Hi @Saurabh7019 FYI, I added another name change regarding |
I just came across |
@Jwaegebaert sure makes sense, please add it to the list 😄 |
Hi Milan, I wanted to clarify that changing the parameter name from "--id" to "--name" without making changes to the code could create confusion for users. After reviewing the code, I noticed that it actually requires the app GUID in order to export the app, rather than the app name. |
Hi @Saurabh7019 you are right. However all other Power App commands are using I internally started a discussion to change all |
This issue is created to keep track of options we should update/rename for the next major
v7
release.aad:
aad user set
objectId
toid
userPrincipalName
touserName
pa:
pa app export
Renameid
to-n, --name
pa app consent set
pa app export
pa app list
environment
toenvironmentName
pp:
pa aibuildermodel get
pa aibuildermodel list
pa aibuildermodel remove
pp card clone
pp card get
pp card list
pp card remove
pp chatbot get
pp chatbot list
pp chatbot remove
pp dataverse table get
pp dataverse table list
pp dataverse table remove
pp dataverse table row list
pp dataverse table row remove
pp solution get
pp solution list
pp solution publish
pp solution remove
pp solution publisher get
pp solution publisher add
pp solution publisher list
pp solution publisher remove
environment
toenvironmentName
spo:
spo listitem attachment list
itemId
tolistItemId
spo user get
loginName
touserName
IMPORTANT
Let's recheck the script samples and update them with the new options.
The text was updated successfully, but these errors were encountered: