Rename options. Closes #4467 #5225
Conversation
|
Awesome job @Saurabh7019! We'll try to review it ASAP! |
There was a problem hiding this comment.
On first sight, one thing I noticed is that you update the options from our sample scripts, which is fantastic, but we should also update the version of it to v7.0.0 in the metadata JSON file located in the assets folder.
|
Also, because I know it's your first major version so I don't blame you at all, just know that every |
Sure! |
docs/docs/v7-upgrade-guidance.mdx
Outdated
| [spo listitem attachment list](./cmd/spo/listitem/listitem-attachment-list.mdx)|`itemId`|`listItemId` | ||
| [spo user get](./cmd/spo/user/user-get.mdx)|`loginName`|`userName` | ||
|
|
||
|
|
There was a problem hiding this comment.
Let's remove this unnecessary empty line
|
Hi @Saurabh7019, we did another v7 release do your PR got messed up. Could you rebase with the latest v7 branch to fix the conflicts? If you encounter any problems, please reach out to us. Thanks! |
docs/docs/cmd/flow/flow-enable.mdx
Outdated
There was a problem hiding this comment.
Since this is something that's incorrect in our docs at this moment. Let's fix it in another PR and merge it with main branch.
| @@ -22,7 +22,7 @@ | |||
| "metadata": [ | |||
| { | |||
| "key": "CLI-FOR-MICROSOFT365", | |||
| "value": "6.3.0" | |||
| "value": "v7.0.0" | |||
There was a problem hiding this comment.
Let's drop the v before the version number.
|
Manually merged. Thank you for the great work! 👏 |
Closes #4467