Added logging

src/m365/pp/commands/solution/solution-publisher-remove.ts

@@ -93,7 +93,7 @@ class PpSolutionPublisherRemoveCommand extends PowerPlatformCommand {
     }
 
     if (args.options.confirm) {
-      await this.deletePublisher(args);
+      await this.deletePublisher(args, logger);
     }
     else {
       const result = await Cli.prompt<{ continue: boolean }>({
@@ -104,25 +104,25 @@ class PpSolutionPublisherRemoveCommand extends PowerPlatformCommand {
       });
 
       if (result.continue) {
-        await this.deletePublisher(args);
+        await this.deletePublisher(args, logger);
       }
     }
   }
 
-  private async getPublisherId(args: CommandArgs, dynamicsApiUrl: string): Promise<any> {
+  private async getPublisherId(args: CommandArgs, dynamicsApiUrl: string, logger: Logger): Promise<any> {
     if (args.options.id) {
       return args.options.id;
     }
 
-    const solutionPublisher = await powerPlatform.getSolutionPublisherByName(dynamicsApiUrl, args.options.name!);
+    const solutionPublisher = await powerPlatform.getSolutionPublisherByName(dynamicsApiUrl, args.options.name!, logger, this.verbose);
     return solutionPublisher.publisherid;
   }
 
-  private async deletePublisher(args: CommandArgs): Promise<void> {
+  private async deletePublisher(args: CommandArgs, logger: Logger): Promise<void> {
     try {
       const dynamicsApiUrl = await powerPlatform.getDynamicsInstanceApiUrl(args.options.environment, args.options.asAdmin);
 
-      const publisherId = await this.getPublisherId(args, dynamicsApiUrl);
+      const publisherId = await this.getPublisherId(args, dynamicsApiUrl, logger);
       const requestOptions: CliRequestOptions = {
         url: `${dynamicsApiUrl}/api/data/v9.1/publishers(${publisherId})`,
         headers: {

src/utils/powerPlatform.spec.ts

@@ -4,6 +4,7 @@ import request from "../request";
 import auth from '../Auth';
 import { powerPlatform } from './powerPlatform';
 import { sinonUtil } from "./sinonUtil";
+import { Logger } from '../cli/Logger';
 
 const validSolutionPublisherName = 'CLI 365 Solution';
 const envUrl = 'https://contoso-dev.api.crm4.dynamics.com';
@@ -22,11 +23,29 @@ const solutionPublisherResponse = {
 };
 
 describe('utils/powerPlatform', () => {
+  let logger: Logger;
+  let log: string[];
+
   before(() => {
     sinon.stub(auth, 'restoreAuth').callsFake(() => Promise.resolve());
     auth.service.connected = true;
   });
 
+  beforeEach(() => {
+    log = [];
+    logger = {
+      log: (msg: string) => {
+        log.push(msg);
+      },
+      logRaw: (msg: string) => {
+        log.push(msg);
+      },
+      logToStderr: (msg: string) => {
+        log.push(msg);
+      }
+    };
+  });
+
   afterEach(() => {
     sinonUtil.restore([
       request.get
@@ -151,7 +170,7 @@ describe('utils/powerPlatform', () => {
       throw `Invalid request ${opts.url}`;
     });
 
-    const actual = await powerPlatform.getSolutionPublisherByName(envUrl, validSolutionPublisherName);
+    const actual = await powerPlatform.getSolutionPublisherByName(envUrl, validSolutionPublisherName, logger, true);
     assert.strictEqual(actual, solutionPublisherResponse.value[0]);
   });
 });

src/utils/powerPlatform.ts

@@ -1,3 +1,4 @@
+import { Logger } from "../cli/Logger";
 import request, { CliRequestOptions } from "../request";
 import { formatting } from "./formatting";
 
@@ -31,7 +32,18 @@ export const powerPlatform = {
     }
   },
 
-  async getSolutionPublisherByName(dynamicsApiUrl: string, name: string): Promise<any> {
+  /**
+ * Get a solution publisher by name
+ * Returns solution publisher object
+ * @param dynamicsApiUrl The dynamics api url of the environment
+ * @param name The name of the solution publisher.
+ * @param logger The logger object
+ * @param verbose Set for verbose logging
+ */
+  async getSolutionPublisherByName(dynamicsApiUrl: string, name: string, logger?: Logger, verbose?: boolean): Promise<any> {
+    if (verbose && logger) {
+      logger.logToStderr(`Retrieving the solution publisher by name ${name}`);
+    }
     const requestOptions: CliRequestOptions = {
       url: `${dynamicsApiUrl}/api/data/v9.0/publishers?$filter=friendlyname eq \'${name}\'&$select=publisherid,uniquename,friendlyname,versionnumber,isreadonly,description,customizationprefix,customizationoptionvalueprefix&api-version=9.1`,
       headers: {