Implement missing last interacted slot property in chiseled bookshelf #6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanCraft623
previously approved these changes
Sep 1, 2024
dktapps
reviewed
Sep 1, 2024
dktapps
added
Category: API
dktapps
approved these changes
Sep 2, 2024
IvanCraft623
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR implements missing
last interacted slotproperty that is used in vanilla worlds for redstone power. Without this PR chiseled bookshelves loaded from vanilla worlds will discard their redstone power level.Source: https://minecraft.wiki/w/Bedrock_Edition_level_format/Block_entity_format#Chiseled_Bookshelf
Changes
API changes
Added the following methods:
ChiseledBookshelf::getLastInteractedSlot() : ?ChiseledBookshelfSlotChiseledBookshelf::setLastInteractedSlot(?ChiseledBookshelfSlot $lastInteractedSlot) : selfTests
Since PM doesn't have redstone implemented, I added some debug messages to the chat locally to test this.