6161 implement interface common block properties

src/block/AmethystCluster.php

@@ -38,7 +38,7 @@
 use pocketmine\utils\AssumptionFailedError;
 use pocketmine\world\BlockTransaction;
 
-final class AmethystCluster extends Transparent{
+final class AmethystCluster extends Transparent implements FacingInterface{
 	use AmethystTrait;
 	use AnyFacingTrait;
 

src/block/FacingInterface.php

@@ -0,0 +1,37 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+ */
+
+declare(strict_types=1);
+
+namespace pocketmine\block;
+
+interface FacingInterface {
+
+	/**
+	 * Get the current facing direction of the block
+	 */
+	public function getFacing() : int;
+
+	/**
+	 * Set the current facing direction of the block
+	 */
+	public function setFacing(int $facing) : object;
+}

src/block/Hopper.php

@@ -34,7 +34,7 @@
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;
 
-class Hopper extends Transparent{
+class Hopper extends Transparent implements FacingInterface{
 	use PoweredByRedstoneTrait;
 
 	private int $facing = Facing::DOWN;

src/block/MobHead.php

@@ -35,7 +35,7 @@
 use function assert;
 use function floor;
 
-class MobHead extends Flowable{
+class MobHead extends Flowable implements FacingInterface{
 	public const MIN_ROTATION = 0;
 	public const MAX_ROTATION = 15;
 

src/block/Stem.php

@@ -31,7 +31,7 @@
 use function array_rand;
 use function mt_rand;
 
-abstract class Stem extends Crops{
+abstract class Stem extends Crops implements FacingInterface{
 	protected int $facing = Facing::UP;
 
 	protected function describeBlockOnlyState(RuntimeDataDescriber $w) : void{

src/block/Torch.php

@@ -31,7 +31,7 @@
 use pocketmine\player\Player;
 use pocketmine\world\BlockTransaction;
 
-class Torch extends Flowable{
+class Torch extends Flowable implements FacingInterface{
 
 	protected int $facing = Facing::UP;
 

src/block/tile/Bell.php

@@ -23,14 +23,15 @@
 
 namespace pocketmine\block\tile;
 
+use pocketmine\block\FacingInterface;
 use pocketmine\math\Facing;
 use pocketmine\nbt\tag\CompoundTag;
 use pocketmine\network\mcpe\protocol\BlockActorDataPacket;
 use pocketmine\network\mcpe\protocol\types\BlockPosition;
 use pocketmine\network\mcpe\protocol\types\CacheableNbt;
 use pocketmine\utils\AssumptionFailedError;
 
-final class Bell extends Spawnable{
+final class Bell extends Spawnable implements FacingInterface{
 	public const TAG_DIRECTION = "Direction"; //TAG_Int
 	public const TAG_RINGING = "Ringing"; //TAG_Byte
 	public const TAG_TICKS = "Ticks"; //TAG_Int
@@ -45,7 +46,10 @@ public function setRinging(bool $ringing) : void{ $this->ringing = $ringing; }
 
 	public function getFacing() : int{ return $this->facing; }
 
-	public function setFacing(int $facing) : void{ $this->facing = $facing; }
+	public function setFacing(int $facing) : self {
+		$this->facing = $facing;
+		return $this;
+	}
 
 	public function getTicks() : int{ return $this->ticks; }
 

src/block/tile/ShulkerBox.php

@@ -23,14 +23,15 @@
 
 namespace pocketmine\block\tile;
 
+use pocketmine\block\FacingInterface;
 use pocketmine\block\inventory\ShulkerBoxInventory;
 use pocketmine\item\Item;
 use pocketmine\math\Facing;
 use pocketmine\math\Vector3;
 use pocketmine\nbt\tag\CompoundTag;
 use pocketmine\world\World;
 
-class ShulkerBox extends Spawnable implements Container, Nameable{
+class ShulkerBox extends Spawnable implements Container, Nameable, FacingInterface{
 	use NameableTrait {
 		addAdditionalSpawnData as addNameSpawnData;
 	}
@@ -89,8 +90,9 @@ public function getFacing() : int{
 		return $this->facing;
 	}
 
-	public function setFacing(int $facing) : void{
+	public function setFacing(int $facing) : self {
 		$this->facing = $facing;
+		return $this;
 	}
 
 	public function getInventory() : ShulkerBoxInventory{

src/entity/object/Painting.php

@@ -23,6 +23,7 @@
 
 namespace pocketmine\entity\object;
 
+use pocketmine\block\FacingInterface;
 use pocketmine\block\VanillaBlocks;
 use pocketmine\entity\Entity;
 use pocketmine\entity\EntitySizeInfo;
@@ -40,7 +41,7 @@
 use pocketmine\world\World;
 use function ceil;
 
-class Painting extends Entity{
+class Painting extends Entity implements FacingInterface{
 	public const TAG_TILE_X = "TileX"; //TAG_Int
 	public const TAG_TILE_Y = "TileY"; //TAG_Int
 	public const TAG_TILE_Z = "TileZ"; //TAG_Int
@@ -176,6 +177,11 @@ public function getFacing() : int{
 		return $this->facing;
 	}
 
+	public function setFacing(int $facing) : self {
+		$this->facing = $facing;
+		return $this;
+	}
+
 	/**
 	 * Returns the bounding-box a painting with the specified motive would have at the given position and direction.
 	 */