Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async task timings #6333

Open
wants to merge 6 commits into
base: minor-next
Choose a base branch
from
Open

Async task timings #6333

wants to merge 6 commits into from
+406 −89

Commits on Apr 19, 2024

  1. Added timings collection for async tasks 

    this is a rough implementation and needs further work.
there's currently an issue where the first async worker to boot up doesn't enable timings if it was enabled by default in pocketmine.yml and I have no idea why - the task definitely gets scheduled so it doesn't make any sense.
    @dktapps
    dktapps committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    850d3ce View commit details
    Browse the repository at this point in the history

  2. Fixed stupid bug in timings paste

    @dktapps
    dktapps committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    867c715 View commit details
    Browse the repository at this point in the history

  3. Add support for enable/disable and reset callbacks 

    we should probably add callbacks for collecting timings too, but that's a bit more complicated right now.
    @dktapps
    dktapps committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9103658 View commit details
    Browse the repository at this point in the history

  4. Added callback collect mechanism 

    this allows custom threads to have timings collected via custom mechanisms, since we can't directly access another thread's timings.
for RakLib, for example, we'll need an IPC command, while for workers we need an AsyncTask.
    @dktapps
    dktapps committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f0161fc View commit details
    Browse the repository at this point in the history

  5. Simplify callback collect when multiple threads are collected by one … 

    …callback
    @dktapps
    dktapps committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    29ad5e1 View commit details
    Browse the repository at this point in the history

  6. Fix PHPStan

    @dktapps
    dktapps committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    06c4c98 View commit details
    Browse the repository at this point in the history