-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented End Crystal #4715
base: minor-next
Are you sure you want to change the base?
Implemented End Crystal #4715
Conversation
Same happens in vanilla |
The explosion behaviour seems to differ from vanilla. In vanilla, no blocks at or below the same Y as the obsidian are destroyed. In this PR, the blocks are destroyed as if a TNT blast went off. |
src/entity/object/EnderCrystal.php
Outdated
public function attack(EntityDamageEvent $source) : void{ | ||
parent::attack($source); | ||
if( | ||
$source->getCause() !== EntityDamageEvent::CAUSE_VOID && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java code suggests that explosion causes should be added to this (end crystals don't explode when destroyed by other end crystals).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(end crystals don't explode when destroyed by other end crystals).
They do it in bedrock
This PR also doesn't include beam targeting ( |
I don’t know what happened, but on my local machine it looked fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look ok to me
The only thing is that I need to fix CS. I’ll do it a little bit later, when I come home |
Introduction
Implemented End Crystal
Changes
Behavioural changes
N/A
Tests
https://www.youtube.com/watch?v=qEakbZGoN9M