Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented End Crystal #4715

Open
wants to merge 24 commits into
base: minor-next
Choose a base branch
from
Open

Implemented End Crystal #4715

wants to merge 24 commits into from

Conversation

ipad54
Copy link
Contributor

@ipad54 ipad54 commented Jan 8, 2022

Introduction

Implemented End Crystal

Changes

Behavioural changes

N/A

Tests

https://www.youtube.com/watch?v=qEakbZGoN9M

@ipad54
Copy link
Contributor Author

ipad54 commented Jan 8, 2022

setShowBase() method works fine
Screenshot_97

@dktapps dktapps added Category: Gameplay Related to Minecraft gameplay experience Type: Contribution labels Jan 18, 2022
src/entity/object/EnderCrystal.php Outdated Show resolved Hide resolved
src/entity/object/EnderCrystal.php Outdated Show resolved Hide resolved
src/entity/object/EnderCrystal.php Outdated Show resolved Hide resolved
src/entity/object/EnderCrystal.php Outdated Show resolved Hide resolved
src/entity/object/EnderCrystal.php Outdated Show resolved Hide resolved
src/item/ItemFactory.php Outdated Show resolved Hide resolved
@dktapps dktapps added Type: Enhancement Contributes features or other improvements to PocketMine-MP and removed Type: Contribution labels Nov 26, 2022
@dktapps dktapps dismissed their stale review July 25, 2023 12:37

outdated

@dktapps
Copy link
Member

dktapps commented Jul 25, 2023

image
Not sure this is supposed to work?

@ipad54
Copy link
Contributor Author

ipad54 commented Jul 25, 2023

Same happens in vanilla

@dktapps
Copy link
Member

dktapps commented Jul 25, 2023

The explosion behaviour seems to differ from vanilla.

In vanilla, no blocks at or below the same Y as the obsidian are destroyed. In this PR, the blocks are destroyed as if a TNT blast went off.

@dktapps
Copy link
Member

dktapps commented Jul 25, 2023

Vanilla EC:
image
Vanilla TNT:
image

public function attack(EntityDamageEvent $source) : void{
parent::attack($source);
if(
$source->getCause() !== EntityDamageEvent::CAUSE_VOID &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java code suggests that explosion causes should be added to this (end crystals don't explode when destroyed by other end crystals).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(end crystals don't explode when destroyed by other end crystals).

They do it in bedrock

@dktapps
Copy link
Member

dktapps commented Jul 25, 2023

This PR also doesn't include beam targeting (EntityMetadataProperties::BLOCK_TARGET property).

@ipad54
Copy link
Contributor Author

ipad54 commented Jul 25, 2023

beam targeting now works
Screenshot_321

src/entity/object/EnderCrystal.php Outdated Show resolved Hide resolved
src/item/EndCrystal.php Show resolved Hide resolved
src/item/EndCrystal.php Show resolved Hide resolved
ipad54 and others added 6 commits August 20, 2024 14:26
Copy link
Member

@ShockedPlot7560 ShockedPlot7560 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look ok to me

@ShockedPlot7560 ShockedPlot7560 requested a review from a team August 21, 2024 07:18
@ipad54
Copy link
Contributor Author

ipad54 commented Aug 21, 2024

The only thing is that I need to fix CS. I’ll do it a little bit later, when I come home

Joshy3282 added a commit to Joshy3282/PocketMine-MP that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Related to Minecraft gameplay experience Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants