Apply suggestions from code review

Co-authored-by: ipad54 <[email protected]>
pmmp · Apr 4, 2024 · 1d924c3 · 1d924c3
1 parent 2d8449e
commit 1d924c3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/inventory/ArmorInventory.php b/src/inventory/ArmorInventory.php
@@ -81,7 +81,7 @@ public function setBoots(Item $boots) : void{
 		$this->setItem(self::SLOT_FEET, $boots);
 	}
 
-	private function validate(Inventory $inventory, Item $item, int $slot) : null|TransactionValidationException{
+	private function validate(Inventory $inventory, Item $item, int $slot) : ?TransactionValidationException{
 		if($item instanceof Armor && $item->getArmorSlot() === $slot){
 			if($item->getArmorSlot() !== $slot){
 				return new TransactionValidationException("Armor item in wrong slot");

diff --git a/src/inventory/transaction/action/SlotChangeAction.php b/src/inventory/transaction/action/SlotChangeAction.php
@@ -78,7 +78,7 @@ public function validate(Player $source) : void{
 		if($this->inventory instanceof SlotSafeInventory && !$this->targetItem->isNull()){
 			foreach($this->inventory->getSlotValidators() as $validator){
 				$ret = $validator->validate($this->inventory, $this->targetItem, $this->inventorySlot);
-				if($ret instanceof TransactionValidationException){
+				if($ret !== null){
 					throw new TransactionValidationException("Target item is not accepted by the inventory slot: " . $ret->getMessage(), 0, $ret);
 				}
 			}