Skip to content

Commit

Permalink
Fixed artifact name collisions
Browse files Browse the repository at this point in the history
I thought these would be namespaced per workflow instance :(
  • Loading branch information
dktapps committed Jan 8, 2024
1 parent 15036ef commit 3461479
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
uses: actions/upload-artifact@v4
if: always()
with:
name: Linux
name: Linux-PM${{ inputs.pm-version-major }}
path: |
./PHP-Linux-x86_64*.tar.gz
install.log
Expand All @@ -60,7 +60,7 @@ jobs:
uses: actions/upload-artifact@v4
if: failure()
with:
name: Linux-workspace
name: Linux-workspace-PM${{ inputs.pm-version-major }}
path: |
workspace.tar.gz
if-no-files-found: error
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
uses: actions/upload-artifact@v4
if: always()
with:
name: MacOS
name: MacOS-PM${{ inputs.pm-version-major }}
path: |
./PHP-MacOS-x86_64*.tar.gz
install.log
Expand All @@ -114,7 +114,7 @@ jobs:
uses: actions/upload-artifact@v4
if: failure()
with:
name: MacOS-workspace
name: MacOS-workspace-PM${{ inputs.pm-version-major }}
path: |
workspace.tar.gz
if-no-files-found: error
Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
uses: actions/upload-artifact@v4
if: always()
with:
name: Windows
name: Windows-PM${{ inputs.pm-version-major }}
path: |
PHP-Windows-x64*.zip
compile.log
Expand Down Expand Up @@ -210,9 +210,9 @@ jobs:
uses: ncipollo/[email protected]
with:
artifacts: |
${{ github.workspace }}/Linux/*.tar.gz
${{ github.workspace }}/MacOS/*.tar.gz
${{ github.workspace }}/Windows/*.zip
${{ github.workspace }}/Linux-PM${{ inputs.pm-version-major }}/*.tar.gz
${{ github.workspace }}/MacOS-PM${{ inputs.pm-version-major }}/*.tar.gz
${{ github.workspace }}/Windows-PM${{ inputs.pm-version-major }}/*.zip
makeLatest: ${{ github.ref_name == github.event.repository.default_branch }}
name: PHP for PocketMine-MP ${{ inputs.pm-version.major }}.x - Latest (Build ${{ github.run_number }})
tag: php-pm${{ inputs.pm-version-major }}-latest
Expand All @@ -225,9 +225,9 @@ jobs:
uses: ncipollo/[email protected]
with:
artifacts: |
${{ github.workspace }}/Linux/*.tar.gz
${{ github.workspace }}/MacOS/*.tar.gz
${{ github.workspace }}/Windows/*.zip
${{ github.workspace }}/Linux-PM${{ inputs.pm-version-major }}/*.tar.gz
${{ github.workspace }}/MacOS-PM${{ inputs.pm-version-major }}/*.tar.gz
${{ github.workspace }}/Windows-PM${{ inputs.pm-version-major }}/*.zip
makeLatest: ${{ github.ref_name == github.event.repository.default_branch }}
name: PHP ${{ steps.version.outputs.PHP_VERSION }} for PocketMine-MP ${{ inputs.pm-version.major }}.x - Latest (Build ${{ github.run_number }})
tag: php-${{ steps.version.outputs.PHP_VERSION }}-pm${{ inputs.pm-version-major }}-latest
Expand All @@ -241,9 +241,9 @@ jobs:
uses: ncipollo/[email protected]
with:
artifacts: |
${{ github.workspace }}/Linux/*.tar.gz
${{ github.workspace }}/MacOS/*.tar.gz
${{ github.workspace }}/Windows/*.zip
${{ github.workspace }}/Linux-PM${{ inputs.pm-version-major }}/*.tar.gz
${{ github.workspace }}/MacOS-PM${{ inputs.pm-version-major }}/*.tar.gz
${{ github.workspace }}/Windows-PM${{ inputs.pm-version-major }}/*.zip
makeLatest: false
name: PHP ${{ steps.version.outputs.PHP_VERSION }} for PocketMine-MP ${{ inputs.pm-version.major }}.x - (Build ${{ github.run_number }})
tag: php-${{ steps.version.outputs.PHP_VERSION }}-pm${{ inputs.pm-version-major }}-build-${{ github.run_number }}
Expand Down

0 comments on commit 3461479

Please sign in to comment.