Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs pmd/pmd#2363, #33
Now the "main attribute" of nodes is displayed in the tree like so:
I think over time this will payoff as we're not dependent on the image anymore to have a "grokkable" tree.
Nodes can be folded by default (the behavior is implemented by the designer) but this is not opted in by any language module yet. A couple of observations on the java tree:
@ImportedName
and it could be folded by default@Name
and not@Image
@AnnotationName
, we could expose rather a@SimpleName
at least, and@BinaryName
based on the type resolution result (and on java-grammar, on the disambiguation result - which makes me realize I forgot to implement disambiguation for annotations)The XPath attributes panel is revamped to a table, "extra info" is listed at the bottom (this includes the type):
As you can see there are now visual cues for deprecated attributes, there is even a tooltip:
Note that those two screenshots were taken on an earlier version, now the attributes are also sorted alphabetically
This is a draft because I'm thinking about adding some styling to the treeview to make it more readable.I think this is ready now. Suggestions are welcome