Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal option layout.autosize='initial' (Fixes #537) #577

Merged
merged 26 commits into from
Jun 9, 2016

Commits on May 27, 2016

  1. autosize: Remove unnecessary guard in plotAutoSize

    * Commit 5df675a (fix demo/outside legend bug and null data autoscale
      bug) introduced a guard in plotAutoSize to avoid calling layoutStyles
      while autosize is set to 'initial'.
    
    * Commit ee974d9 (autosizing in shareplots, autosize aspect ratio
      restrictions and ...) removed the call to layoutStyles but forgot to
      remove the guard.
    
    * This commit removes the guard.
    
    * Checked that all the jasmine and image tests still pass.
    n-riesco committed May 27, 2016
    Configuration menu
    Copy the full SHA
    f1415f8 View commit details
    Browse the repository at this point in the history
  2. autosize: remove internal option 'initial'

    * Moved initial call to `plotAutoSize` into `Plots.supplyDefaults(gd)`.
    
    * Replaced `{ autosize: 'initial' }` with the flag
      `gd._fullLayout._initialAutoSizeIsDone`.
    
    * `{ autosize: false }` the values of width and height undefined in
      `gd.layout` will be autosized only once.
    
    * `{ autosize: true }` only autosizes the values of width and height
      undefined in `gd.layout`.
    
    Fixes plotly#537
    n-riesco committed May 27, 2016
    Configuration menu
    Copy the full SHA
    3a2c547 View commit details
    Browse the repository at this point in the history
  3. autosize: update baseline image ternary_simple

    * Previous image didn't honour the width and height set in the layout.
    n-riesco committed May 27, 2016
    Configuration menu
    Copy the full SHA
    f9140b0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    206888b View commit details
    Browse the repository at this point in the history
  5. test: add test for issue plotly#537

    * Added test to check `Plotly.newPlot` respects `layout.width` and
      `layout.height`.
    n-riesco committed May 27, 2016
    Configuration menu
    Copy the full SHA
    9c2a0d9 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2016

  1. Configuration menu
    Copy the full SHA
    53d4b90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    61aa240 View commit details
    Browse the repository at this point in the history
  3. autosize: supplyDefaults accepts plain objects

    * Fix bug in `plotAutoSize`, triggered when `autosize` and `frameMagins`
      are both enabled and `gd` is a plain object.
    
    * Ensure `autosize` doesn't set values of width and height smaller than
      the minimum defined in the corresponding layout attribute.
    n-riesco committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    a334254 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7815efe View commit details
    Browse the repository at this point in the history
  5. autosize: respect config.autosizable

    * Do not do the initial autosize if both config.autosizable and
      layout.autosize are false.
    n-riesco committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    7e95d93 View commit details
    Browse the repository at this point in the history
  6. test: config.autosizable

    n-riesco committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    370ad8b View commit details
    Browse the repository at this point in the history
  7. autosize: supplyDefaults accepts plain objects

    * Fix bug introduced in the commit for respecting `config.autosizable`.
    n-riesco committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    46d7af5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    94f450a View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2016

  1. Configuration menu
    Copy the full SHA
    b286469 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    49bb2cf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0c316ba View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3ed69b1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    862578e View commit details
    Browse the repository at this point in the history
  6. autosize: restore backwards-compatibility with v1

    * Initialise `layout.width` and `layout.height` if `autosize` is false.
    n-riesco committed Jun 7, 2016
    Configuration menu
    Copy the full SHA
    172d81d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    42a3ed0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    de69b3d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ada5323 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    bc1a970 View commit details
    Browse the repository at this point in the history
  11. autosize: use Lib.isPlotDiv

    n-riesco committed Jun 7, 2016
    Configuration menu
    Copy the full SHA
    6021c43 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e822ff7 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2016

  1. Configuration menu
    Copy the full SHA
    fbc01c3 View commit details
    Browse the repository at this point in the history