Add language independent field icon. #6298
Open
+117
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
davisagli
requested changes
Sep 18, 2024
There was a problem hiding this comment.
@iRohitSingh Please take note of the checks which failed on this PR. It looks like you need to:
- Add the changelog
- Update test snapshots
- Update i18n
stevepiercy
requested changes
Sep 18, 2024
packages/volto/src/components/manage/Widgets/FormFieldWrapper.jsx
Outdated
Show resolved
Hide resolved
davisagli
reviewed
Sep 18, 2024
stevepiercy
approved these changes
Sep 19, 2024
Ok. I am investigating it. |
davisagli
reviewed
Sep 19, 2024
| )} | ||
| > | ||
| <Grid> | ||
| <Grid.Row stretched> | ||
| {columns === 2 && ( | ||
| <Grid.Column width="4"> | ||
| <div className="wrapper"> | ||
| <div className="wrapper title-icon-container"> |
There was a problem hiding this comment.
Seeing all the snapshots that were updated makes me wonder:
- Do we need the
title-icon-containerclass even for the fields that don't have an icon? - Should we just apply the flex styles to all field wrappers and not add the new class?
/cc @sneridagh
There was a problem hiding this comment.
I agree with David, although I can see that write a class enough specific to match only that wrapper can be difficult. @iRohitSingh can you look into that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6297