Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join validation errors in one single toast and update api error resp #6295

Merged
merged 5 commits into from
Sep 28, 2024

Conversation

cekk
Copy link
Member

@cekk cekk commented Sep 17, 2024

With this changes error messages (and labels on single fields) are updated each time a POST/PATCH return a validation error (before this, error messages in fields weren't updated).

I've also joined error messages in one single toast because i've found that raising multiple toasts, only last will be shown.
For me it's also more readable a single toast with all the informations, but this can be reverted if you don't like it (i had to change also a wrapper into Toast component to allow insert an ul tag).

This is an example of the result:

Screenshot 2024-09-24 alle 15 20 58

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 8964696
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66f7a9f963cc9d00083a3ecc

@cekk cekk marked this pull request as ready for review September 24, 2024 14:38
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: the list items look like they have too much indent on the left.

Otherwise LGTM.

@pnicolli pnicolli merged commit 6fbd414 into main Sep 28, 2024
70 checks passed
@pnicolli pnicolli deleted the cekk_improve_error_messages branch September 28, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants