Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FormFieldWrapper to Functional Component #6190

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

abhay-dev2901
Copy link

Refactored FormFieldWrapper from a class-based to a functional component. Key updates include:

  • Converted to functional component using React hooks.
  • Implemented useIntl for internationalization.
  • Updated Semantic UI components (Form, Grid, Icon, Label).
  • Managed conditional class names with classnames.
  • Preserved existing functionality and prop handling.

Changes:

  • Replaced IconOld with Icon.
  • Used useIntl for message handling.
  • Ensured prop handling and error display remain consistent.

Testing:

  • Verified component functionality and UI consistency.

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 10cd0c4
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66a37df8d015c900085eafe0

@stevepiercy
Copy link
Collaborator

@abhay-dev2901 please read and follow Code quality. You should run all of these checks locally to ensure they pass before creating a pull request. Then you can compare your results against the GitHub workflows.

See also Update your pull request from your fork.

@stevepiercy
Copy link
Collaborator

@abhay-dev2901 Unit tests fail in CI. CI must pass. Please run tests locally.

See also Update your pull request from your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants