Image full alignment size issue on edit#5936 #6166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the styling of the full aligned images size problem by changing padding-left and width values depending on the sidebar and toolbar position
✅ Deploy Preview for plone-components canceled.
|
stevepiercy
requested changes
Jul 20, 2024
stevepiercy
approved these changes
Jul 20, 2024
nileshgulia1
reviewed
Aug 2, 2024
| .view-editview { | ||
| &.has-sidebar { | ||
| .block.align.full img { | ||
| width: calc(100vw - 375px) !important; |
There was a problem hiding this comment.
@cihanandac We can't do this. If you change the width in edit view. How will a user know its applied a full width, which means the viewport width? Ideally in Volto we wish to keep Edit and View display components the same. For eg:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #5936
This change fixes the full aligned images size problem on the edit screen by changing the padding-left and width values. Transitions are set so that opening/closing of sidebar and toolbar would look seamless.