Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support dtmf param on verify request #217

Merged
merged 1 commit into from
Oct 10, 2024
Merged

support dtmf param on verify request #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# Change Log
## [7.53.0](https://github.com/plivo/plivo-go/tree/v7.53.0) (2024-10-10)
**Feature - Dtmf param in Create, Get and List Session**
- Support for the `dtmf` parameter in voice verify session request
- Added support for `dtmf` in GET and LIST verify session.

## [7.52.0](https://github.com/plivo/plivo-go/tree/v7.52.0) (2024-09-30)
**Feature - Adding new param support for Number Masking session with single party **
- Added `create_session_with_single_party`, `virtual_number_cooloff_period` and `force_pin_authentication` attributes in Masking Session
Expand Down
2 changes: 1 addition & 1 deletion baseclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"encoding/json"
"errors"
"fmt"
"io/ioutil"

Check failure on line 8 in baseclient.go

View workflow job for this annotation

GitHub Actions / lint 

SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (staticcheck)
"net/http"
"net/url"
"reflect"
Expand All @@ -13,7 +13,7 @@
"github.com/google/go-querystring/query"
)

const sdkVersion = "7.52.0"
const sdkVersion = "7.53.0"

const lookupBaseUrl = "lookup.plivo.com"

Expand Down
5 changes: 3 additions & 2 deletions fixtures/verifySessionListResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,16 @@
"session_uuid": "7b28af5c-3e25-45e2-be1e-9235e00dc87a",
"app_uuid": "3cdec449-a367-435e-b4f9-40d777a7cfcc",
"recipient": "918707046409",
"channel": "sms",
"channel": "voice",
"status": "expired",
"count": 1,
"attempt_details": [
{
"channel": "sms",
"attempt_uuid": "f26731c0-d076-42d3-b678-264b0a610b87",
"status": "failed",
"time": "2023-07-20T08:02:18.981765Z"
"time": "2023-07-20T08:02:18.981765Z",
"dtmf": 9
}
],
"charges": {
Expand Down
2 changes: 2 additions & 0 deletions verify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ type AttemptDetails struct {
AppHash string `json:"app_hash,omitempty"`
CodeLength int `json:"code_length,omitempty"`
Time time.Time `json:"time,omitempty"`
Dtmf *int `json:"dtmf,omitempty"`
}

type Charges struct {
Expand All @@ -73,6 +74,7 @@ type SessionCreateParams struct {
BrandName string `json:"brand_name,omitempty"`
AppHash string `json:"app_hash,omitempty"`
CodeLength int `json:"code_length,omitempty"`
Dtmf *int `json:"dtmf,omitempty"`
}

type SessionCreateResponseBody struct {
Expand Down
Loading