Removing timeouts from jobs (project-chip#27447)

plauric · Jun 26, 2023 · 4f14a6c · 4f14a6c
1 parent 2f33181
commit 4f14a6c
Show file tree

Hide file tree

Showing 36 changed files with 1 addition and 250 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -37,7 +37,6 @@ env:
 jobs:
     build_linux_gcc_debug:
         name: Build on Linux (gcc_debug)
-        timeout-minutes: 85
 
         runs-on: ubuntu-latest
         if: github.actor != 'restyled-io[bot]'
@@ -88,7 +87,6 @@ jobs:
                         .environment
                         build_overrides/pigweed_environment.gni
             - name: Bootstrap
-              timeout-minutes: 10
               run: bash scripts/bootstrap.sh
             - name: Uploading bootstrap logs
               uses: actions/upload-artifact@v3
@@ -107,10 +105,8 @@ jobs:
             - name: Setup Build
               run: scripts/build/gn_gen.sh --args="chip_config_memory_debug_checks=true chip_config_memory_debug_dmalloc=false"
             - name: Run Build
-              timeout-minutes: 20
               run: scripts/run_in_build_env.sh "ninja -C ./out"
             - name: Run Tests
-              timeout-minutes: 30
               run: scripts/tests/gn_tests.sh
             # TODO Log Upload https://github.com/project-chip/connectedhomeip/issues/2227
             # TODO https://github.com/project-chip/connectedhomeip/issues/1512
@@ -123,17 +119,14 @@ jobs:
             - name: Setup Build Without Detail Logging
               run: scripts/build/gn_gen.sh --args="chip_detail_logging=false"
             - name: Run Build Without Detail Logging
-              timeout-minutes: 20
               run: scripts/run_in_build_env.sh "ninja -C ./out"
             - name: Setup Build Without Progress Logging
               run: scripts/build/gn_gen.sh --args="chip_detail_logging=false chip_progress_logging=false"
             - name: Run Build Without Progress Logging
-              timeout-minutes: 20
               run: scripts/run_in_build_env.sh "ninja -C ./out"
             - name: Setup Build Without Error Logging
               run: scripts/build/gn_gen.sh --args="chip_detail_logging=false chip_progress_logging=false chip_error_logging=false"
             - name: Run Build Without Error Logging
-              timeout-minutes: 20
               run: scripts/run_in_build_env.sh "ninja -C ./out"
             - name: Uploading core files
               uses: actions/upload-artifact@v3
@@ -189,7 +182,6 @@ jobs:
 
     build_linux:
         name: Build on Linux (fake, gcc_release, clang, simulated)
-        timeout-minutes: 150
 
         runs-on: ubuntu-latest
         if: github.actor != 'restyled-io[bot]'
@@ -240,7 +232,6 @@ jobs:
                         .environment
                         build_overrides/pigweed_environment.gni
             - name: Bootstrap
-              timeout-minutes: 10
               run: bash scripts/bootstrap.sh
             - name: Uploading bootstrap logs
               uses: actions/upload-artifact@v3
@@ -256,21 +247,18 @@ jobs:
               with:
                   languages: "cpp"
             - name: Setup and Build Simulated Device
-              timeout-minutes: 20
               run: |
                   BUILD_TYPE=simulated
                   GN_ARGS='chip_tests_zap_config="app1" chip_project_config_include_dirs=["../../examples/placeholder/linux/apps/app1/include", "../../config/standalone"] chip_config_network_layer_ble=false'
                   CHIP_ROOT_PATH=examples/placeholder/linux
                   CHIP_ROOT_PATH="$CHIP_ROOT_PATH" BUILD_TYPE="$BUILD_TYPE" scripts/build/gn_gen.sh --args="$GN_ARGS"
                   scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"
             - name: Setup Build, Run Build and Run Tests
-              timeout-minutes: 90
               run: |
                   BUILD_TYPE=gcc_release scripts/build/gn_gen.sh --args="is_debug=false"
                   scripts/run_in_build_env.sh "ninja -C ./out/gcc_release"
                   BUILD_TYPE=gcc_release scripts/tests/gn_tests.sh
             - name: Run Tests with sanitizers
-              timeout-minutes: 60
               env:
                   LSAN_OPTIONS: detect_leaks=1
               run: |
@@ -287,11 +275,9 @@ jobs:
                       BUILD_TYPE=sanitizers scripts/tests/gn_tests.sh
                   done
             - name: Ensure codegen is done for sanitize
-              timeout-minutes: 45
               run: |
                   ./scripts/run_in_build_env.sh "./scripts/run_codegen_targets.sh out/sanitizers"
             - name: Clang-tidy validation
-              timeout-minutes: 60
               run: |
                   ./scripts/run_in_build_env.sh \
                     "./scripts/run-clang-tidy-on-compile-commands.py \
@@ -300,7 +286,6 @@ jobs:
                        check \
                     "
             - name: Build using build_examples.py
-              timeout-minutes: 60
               run: |
                   ./scripts/run_in_build_env.sh \
                     "./scripts/build/build_examples.py \
@@ -315,7 +300,6 @@ jobs:
             - name: Clean output
               run: rm -rf ./out
             - name: Build using build_examples.py (pregen)
-              timeout-minutes: 60
               run: |
                   ./scripts/run_in_build_env.sh \
                     "./scripts/build/build_examples.py \
@@ -337,7 +321,6 @@ jobs:
                   rm -rf ./zzz_pregenerated
                   mv scripts/codegen.py.renamed scripts/codegen.py
             - name: Run fake linux tests with build_examples
-              timeout-minutes: 15
               run: |
                   ./scripts/run_in_build_env.sh \
                     "./scripts/build/build_examples.py --target linux-fake-tests build"
@@ -395,7 +378,6 @@ jobs:
 
     build_linux_python_lib:
         name: Build on Linux (python_lib)
-        timeout-minutes: 60
 
         runs-on: ubuntu-latest
         if: github.actor != 'restyled-io[bot]'
@@ -441,33 +423,28 @@ jobs:
                         .environment
                         build_overrides/pigweed_environment.gni
             - name: Bootstrap
-              timeout-minutes: 10
               run: bash scripts/bootstrap.sh
 
             - name: Setup Build, Run Build and Run Tests
-              timeout-minutes: 50
               run: |
                   scripts/build/gn_gen.sh --args="enable_rtti=true enable_pylib=true chip_config_memory_debug_checks=false chip_config_memory_debug_dmalloc=false"
                   scripts/run_in_build_env.sh "ninja -C ./out"
                   scripts/tests/gn_tests.sh
             - name: Run Python library specific unit tests
-              timeout-minutes: 5
               run: |
                   scripts/run_in_build_env.sh 'pip3 install ./out/controller/python/chip_core-0.0-cp37-abi3-linux_x86_64.whl'
                   scripts/run_in_build_env.sh 'pip3 install ./out/controller/python/chip_clusters-0.0-py3-none-any.whl'
                   scripts/run_in_build_env.sh 'pip3 install ./out/controller/python/chip_repl-0.0-py3-none-any.whl'
                   scripts/run_in_build_env.sh '(cd src/controller/python/test/unit_tests/ && python3 -m unittest -v)'
 
             - name: Run Python Setup Payload Generator Test
-              timeout-minutes: 20
               run: |
                   scripts/run_in_build_env.sh 'scripts/examples/gn_build_example.sh examples/chip-tool out/'
                   scripts/run_in_build_env.sh 'pip3 install -r src/setup_payload/python/requirements.txt'
                   scripts/run_in_build_env.sh 'python3 src/setup_payload/tests/run_python_setup_payload_gen_test.py out/chip-tool'
 
     build_darwin:
         name: Build on Darwin (clang, python_lib, simulated)
-        timeout-minutes: 200
         runs-on: macos-latest
         if: github.actor != 'restyled-io[bot]'
 
@@ -500,7 +477,6 @@ jobs:
                         .environment
                         build_overrides/pigweed_environment.gni
             - name: Bootstrap
-              timeout-minutes: 25
               run: bash scripts/bootstrap.sh
             - name: Uploading bootstrap logs
               uses: actions/upload-artifact@v3
@@ -517,15 +493,13 @@ jobs:
               with:
                   languages: "cpp"
             - name: Setup and Build Simulated Device
-              timeout-minutes: 20
               run: |
                   BUILD_TYPE=simulated
                   GN_ARGS='chip_tests_zap_config="app1" chip_project_config_include_dirs=["../../examples/placeholder/linux/apps/app1/include", "../../config/standalone"] chip_config_network_layer_ble=false'
                   CHIP_ROOT_PATH=examples/placeholder/linux
                   CHIP_ROOT_PATH="$CHIP_ROOT_PATH" BUILD_TYPE="$BUILD_TYPE" scripts/build/gn_gen.sh --args="$GN_ARGS"
                   scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"
             - name: Setup Build, Run Build and Run Tests
-              timeout-minutes: 120
               # We can't enable leak checking here in LSAN_OPTIONS, because on
               # Darwin that's only supported with a new enough clang, and we're
               # not building with the pigweed clang here.
@@ -547,11 +521,9 @@ jobs:
                       BUILD_TYPE=$BUILD_TYPE scripts/tests/gn_tests.sh
                   done
             - name: Ensure codegen is done for sanitize
-              timeout-minutes: 45
               run: |
                   ./scripts/run_in_build_env.sh "./scripts/run_codegen_targets.sh out/default"
             - name: Clang-tidy validation
-              timeout-minutes: 60
               run: |
                   ./scripts/run_in_build_env.sh \
                     "./scripts/run-clang-tidy-on-compile-commands.py \
@@ -599,7 +571,6 @@ jobs:
 
     build_linux_gcc_coverage:
         name: Build on Linux (coverage)
-        timeout-minutes: 85
 
         runs-on: ubuntu-latest
         if: github.actor != 'restyled-io[bot]'
@@ -637,7 +608,6 @@ jobs:
                         .environment
                         build_overrides/pigweed_environment.gni
             - name: Bootstrap
-              timeout-minutes: 10
               run: bash scripts/bootstrap.sh
             - name: Uploading bootstrap logs
               uses: actions/upload-artifact@v3
@@ -649,5 +619,4 @@ jobs:
                       .environment/pigweed-venv/*.log
 
             - name: Run Build Coverage
-              timeout-minutes: 30
               run: ./scripts/build_coverage.sh
diff --git a/.github/workflows/chef.yaml b/.github/workflows/chef.yaml
@@ -63,7 +63,6 @@ jobs:
                         .environment
                         build_overrides/pigweed_environment.gni
             - name: Bootstrap
-              timeout-minutes: 10
               run: bash scripts/bootstrap.sh
             - name: CI Examples Linux
               shell: bash
@@ -104,7 +103,6 @@ jobs:
                         .environment
                         build_overrides/pigweed_environment.gni
             - name: Bootstrap
-              timeout-minutes: 10
               run: bash scripts/bootstrap.sh
             - name: CI Examples ESP32
               shell: bash
@@ -145,7 +143,6 @@ jobs:
                         .environment
                         build_overrides/pigweed_environment.gni
             - name: Bootstrap
-              timeout-minutes: 10
               run: bash scripts/bootstrap.sh
             - name: CI Examples NRFConnect
               shell: bash

diff --git a/.github/workflows/cirque.yaml b/.github/workflows/cirque.yaml
@@ -32,7 +32,6 @@ env:
 jobs:
     cirque:
         name: Cirque
-        timeout-minutes: 90
 
         env:
             DOCKER_RUN_VERSION: 0.7.3
@@ -79,7 +78,6 @@ jobs:
                         .environment
                         build_overrides/pigweed_environment.gni
             - name: Bootstrap
-              timeout-minutes: 15
               run: |
                   integrations/docker/images/chip-build-cirque/run.sh \
                     -- sh -c " \
@@ -94,8 +92,8 @@ jobs:
             - uses: Wandalen/[email protected]
               name: Cirque Bootstrap cache
               if: ${{ !env.ACT }}
-              timeout-minutes: 10
               continue-on-error: true
+              timeout-minutes: 10
               with:
                 action: buildjet/cache@v3
                 attempt_limit: 3
@@ -105,7 +103,6 @@ jobs:
                   restore-keys: ${{ runner.os }}-cirque-
                   path: ${{ env.GITHUB_CACHE_PATH }}
             - name: Cirque Bootstrap
-              timeout-minutes: 15
               run: |
                   integrations/docker/images/chip-build-cirque/run.sh \
                     --env GITHUB_ACTION_RUN=1 \
@@ -122,15 +119,13 @@ jobs:
                   if_true: "${{ github.sha }}"
                   if_false: "pull-${{ github.event.pull_request.number }}"
             - name: Build Binaries
-              timeout-minutes: 30
               run: |
                   integrations/docker/images/chip-build-cirque/run.sh \
                     -- sh -c " \
                        git config --global --add safe.directory '*' \
                        && scripts/build/gn_gen_cirque.sh \
                       "
             - name: Run Tests
-              timeout-minutes: 45
               run: |
                   integrations/docker/images/chip-build-cirque/run.sh \
                      --env LOG_DIR=/tmp/cirque_test_output \

diff --git a/.github/workflows/darwin-tests.yaml b/.github/workflows/darwin-tests.yaml
@@ -34,7 +34,6 @@ env:
 jobs:
     test_suites_chip_tool_darwin:
         name: Test Suites - Darwin
-        timeout-minutes: 150
 
         strategy:
             matrix:
@@ -82,7 +81,6 @@ jobs:
                         .environment
                         build_overrides/pigweed_environment.gni
             - name: Bootstrap
-              timeout-minutes: 25
               run: bash scripts/bootstrap.sh
             - name: Uploading bootstrap logs
               uses: actions/upload-artifact@v3
@@ -112,7 +110,6 @@ jobs:
               run: xcodebuild clean
               working-directory: src/darwin/Framework
             - name: Build Apps
-              timeout-minutes: 90
               run: |
                   ./scripts/run_in_build_env.sh \
                      "./scripts/build/build_examples.py \
@@ -127,7 +124,6 @@ jobs:
                         --copy-artifacts-to objdir-clone \
                      "
             - name: Run Tests
-              timeout-minutes: 65
               run: |
                   ./scripts/run_in_build_env.sh \
                   "./scripts/tests/run_test_suite.py \
@@ -144,7 +140,6 @@ jobs:
                      --bridge-app ./out/darwin-x64-bridge-${BUILD_VARIANT}/chip-bridge-app \
                   "
             - name: Run OTA Test
-              timeout-minutes: 5
               run: |
                   ./scripts/run_in_build_env.sh \
                   "./scripts/tests/run_darwin_framework_ota_test.py \