update so 1.1 should pass the tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 8, 2019 16:26
|
Should now also pass for julia 1.0. |
|
Thanks for taking a look at this! The functionality in unwrap has moved to DSP.jl (see JuliaDSP/DSP.jl#196 JuliaDSP/DSP.jl#201), I'll add a note in the README to make this more clear. However, it does make sense for Unwrap to continue in case anyone would like a lighter-weight dependency, so I appreciate the updates. Can you add a |
|
Is all the functionality in DSP.jl? I thought only the 1D transform was contributed. I'll add a project.toml file as well. |
|
I'm not sure what to put in the authors and the version field |
|
@platawiec is there anything still missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to update the package so it passes the tests in 1.1
On my local machine(windows julia 1.1) the tests passed.
Please check if the results are still correct.