-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update so 1.1 should pass the tests #8
Conversation
Should now also pass for julia 1.0. |
Thanks for taking a look at this! The functionality in unwrap has moved to DSP.jl (see JuliaDSP/DSP.jl#196 JuliaDSP/DSP.jl#201), I'll add a note in the README to make this more clear. However, it does make sense for Unwrap to continue in case anyone would like a lighter-weight dependency, so I appreciate the updates. Can you add a |
Is all the functionality in DSP.jl? I thought only the 1D transform was contributed. I'll add a project.toml file as well. |
I'm not sure what to put in the authors and the version field |
@platawiec is there anything still missing? |
I tried to update the package so it passes the tests in 1.1
On my local machine(windows julia 1.1) the tests passed.
Please check if the results are still correct.