-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for gxp #191 - allow automatic wildcard attachment in LIKE Filters #205
Conversation
Since this is search/query related and not filter related, this should be implemented in the QueryPanel, not in the FilterBuilder. And I think something like |
Ok, for the renaming My reasoning was that FilterBuilder creates Filter objects such as:
and would, like
Basically what |
matchCase is different, because you can round-trip that without modifying the filter string. If you want to round-trip a filter that you used attachWildCards on, your filter string would change because of the added wildcard strings. This is why I don't think that FilterBuilder is the right place. And yes, QueryBuilder#getFilter would be the place to implement that. Regarding the property name, I think that people will be looking for a way to search substrings, and a property name that tells about wildcards but not substrings may be hard to find. Hence I'd prefer something with |
Ok, new implementation committed. |
fix for gxp #191 - allow automatic wildcard attachment in LIKE Filters
Thanks Andreas, also for your insightful comments. |
See GXP issue #191. Already fixed some time ago and confirm working at several sites. Appearantly I forgot to make a Pull request. Together with issue #189 (QueryPanel: allow case-insensitive string comparison WFS Filters) which has been already merged, automatic wildcard attachment in the case of LIKE Filters is very useful, as this is user-intuitive. See an example here:
http://lib.heron-mc.org/heron/latest/examples/querybuilder and try
STATE_NAME LIKE al
(Alabama+California). Both case insensitive match and wildcarding is applied. Both are configurable (default is false).
GeoExt had in addition the option to either pre and/or postpend wildcards, but this I think is not really required for most uses.