Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication in the encoder #15

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Remove duplication in the encoder #15

wants to merge 8 commits into from

Commits on Feb 16, 2019

  1. simplify (and speed up) header output checks

    @ap
    ap committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    9b84c33 View commit details
    Browse the repository at this point in the history

  2. turn conditional block into guard

    @ap
    ap committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    0bd26db View commit details
    Browse the repository at this point in the history

  3. extract common code to crank the encoder

    @ap
    ap committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    54c283b View commit details
    Browse the repository at this point in the history

  4. extract common return case

    @ap
    ap committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    e7837c9 View commit details
    Browse the repository at this point in the history

  5. extract common header generation

    @ap
    ap committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    3d8b3d1 View commit details
    Browse the repository at this point in the history

  6. flip conditions for readability

    @ap
    ap committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    9fe4b01 View commit details
    Browse the repository at this point in the history

  7. skip CRC computation for deflate

    @ap
    ap committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    088f848 View commit details
    Browse the repository at this point in the history

  8. cache gzip encoding string comparison

    @ap
    ap committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    f5b6194 View commit details
    Browse the repository at this point in the history