Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#9899 Job unit tests patch #4426

Open
wants to merge 8 commits into
base: stable-3_4_0
Choose a base branch
from
Open

pkp/pkp-lib#9899 Job unit tests patch #4426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
38f6093
pkp/pkp-lib#9899 Submodule Update ##touhidurabir/i9899_patch_stable_3…
touhidurabir Sep 4, 2024
8bb712f
pkp/pkp-lib#9899 Submodule Update ##touhidurabir/i9899_patch_stable_3…
touhidurabir Sep 5, 2024
0ba3506
pkp/pkp-lib#9899 Updated deposite issue tests with mocked job class
touhidurabir Sep 6, 2024
4c3d9dc
pkp/pkp-lib#9899 Submodule Update ##touhidurabir/i9899_patch_stable_3…
touhidurabir Sep 6, 2024
585fb73
pkp/pkp-lib#9899 removed direct mocking of job class
touhidurabir Sep 8, 2024
7c51cd8
pkp/pkp-lib#9899 Submodule Update ##touhidurabir/i9899_patch_stable_3…
touhidurabir Sep 8, 2024
afc7799
pkp/pkp-lib#9899 Submodule Update ##touhidurabir/i9899_patch_stable_3…
touhidurabir Sep 8, 2024
55a6f54
pkp/pkp-lib#9899 Submodule Update ##touhidurabir/i9899_patch_stable_3…
touhidurabir Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pkp
Open in desktop
Submodule pkp updated 20 files
+2 −1 classes/controllers/grid/DateGridCellProvider.php
+1 −1 classes/mail/variables/ReviewAssignmentEmailVariable.php
+1 −1 classes/query/QueryDAO.php
+2 −1 classes/services/PKPStatsServiceTrait.php
+10 −0 classes/template/PKPTemplateManager.php
+4 −1 controllers/grid/files/FileDateGridColumn.php
+3 −2 controllers/grid/queries/QueriesGridCellProvider.php
+1 −1 controllers/grid/queries/QueriesGridHandler.php
+2 −1 controllers/grid/queries/QueryNotesGridCellProvider.php
+6 −3 controllers/grid/queries/QueryNotesGridHandler.php
+4 −1 templates/controllers/grid/settings/category/form/categoryForm.tpl
+1 −1 tests/jobs/bulk/BulkEmailSenderTest.php
+46 −11 tests/jobs/doi/DepositSubmissionTest.php
+2 −2 tests/jobs/email/EditorialReminderTest.php
+1 −1 tests/jobs/notifications/NewAnnouncementNotifyUsersTest.php
+2 −2 tests/jobs/notifications/StatisticsReportMailTest.php
+24 −7 tests/jobs/notifications/StatisticsReportNotifyTest.php
+1 −1 tests/jobs/statistics/CompileMonthlyMetricsTest.php
+1 −1 tests/phpunit.xml
+88 −0 tests/support/DoiRegistrationAgency.php
18 changes: 14 additions & 4 deletions tests/jobs/doi/DepositIssueTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

namespace APP\tests\jobs\doi;

use APP\core\Application;
use APP\doi\Repository as DoiRepository;
use APP\issue\Repository as IssueRepository;
use APP\jobs\doi\DepositIssue;
Expand Down Expand Up @@ -53,9 +54,6 @@ public function testRunSerializedJob(): void

$this->mockGuzzleClient();

/** @var DepositIssue $depositIssueJob */
$depositIssueJob = unserialize($this->serializedJobData);

$issueMock = Mockery::mock(\APP\issue\Issue::class)
->makePartial()
->shouldReceive([
Expand Down Expand Up @@ -100,6 +98,18 @@ public function testRunSerializedJob(): void

app()->instance(DoiRepository::class, $doiRepoMock);

$this->assertNull($depositIssueJob->handle());
/** @var \PKP\context\Context $contextMock */
$contextMock = Mockery::mock(get_class(Application::getContextDAO()->newDataObject()))
->makePartial()
->shouldReceive('getData')
->getMock();

$depositIssueMock = new DepositIssue(
0,
$contextMock,
new \PKP\tests\support\DoiRegistrationAgency()
);

$this->assertNull($depositIssueMock->handle());
}
}