Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust disabled media IP version according to offer #4025

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

sauwming
Copy link
Member

To fix #4020.

If we reject a media offer, currently we only take into account the local setting, so even if the offer is IPv4, such as:

m=audio 31002 RTP/SAVP 0 8 96 97 9 18 101
c=IN IP4 10.207.114.11

the answer can be:

m=audio 0 RTP/SAVP 0 8 96 97 9 18 101
c=IN IP6 ::1

In this patch, we will try to check the remote SDP IP version instead.

@sauwming sauwming self-assigned this Jul 29, 2024
@sauwming sauwming added this to the release-2.15 milestone Jul 29, 2024
@sauwming sauwming merged commit 1caa625 into master Jul 31, 2024
36 checks passed
@sauwming sauwming deleted the media_ip_ver branch July 31, 2024 01:08
@henk-van-der-vaart
Copy link

Can anyone give an indication if and when the ETA (release date) of PJSIP 2.15 is expected?
I am especially interested in 2.15 release for fix #4020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about "c" line content in SDP media answer
3 participants