Prevent race condition within DNS callbacks in pjsip resolver #3991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our DNS resolver, in order to avoid deadlock, we utilize a workaround in #1108 by releasing the lock before calling the callback.
However, this means that there can be a race condition. In sip_resolve, it is reported that the callback can be called twice when DNS A and AAAA responses are processed at the same time: