Added ability in stream to modify video codec framerate #3930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately modifying framerate is not that simple, since it not only involves the codec, but also other components such as video stream, otherwise the video stream may not know that the framerate has changed. There's also the issue with SDP negotiation which may limit the framerate that can be sent, so bypassing this may not be a good idea. So, for major modifications such as resolution and/or fps, it may be better to send re-INVITE with REINIT_MEDIA instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openh264 codec supports dynamic change of
bitrateandframerate. This pull request contains functionality with which we can modify framerate of encoding stream after the codec is open withSetOptionAPI of openh264.