Clear thread local error queue prior to calling SSL_* I/O functions #3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions, sometimes other connections leave stale errors which will be returned and falsely attributed to the current SSL connection when calling SSL_get_error()
sauwming
approved these changes
Jul 17, 2023
trengginas
approved these changes
Jul 17, 2023
nanangizz
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't clear the thread local error queue with ERR_clear_error() prior to calling SSL_read/_write/etc functions, sometimes other bad/dead/ending connections leave stale errors which can be returned and falsely attributed to the current (and just fine) SSL connection when calling SSL_get_error()
For more details see issue #3632